Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support to parse sub-aggregations from filter/nested aggregations #234

Merged
merged 17 commits into from
Oct 21, 2022
Merged

Add support to parse sub-aggregations from filter/nested aggregations #234

merged 17 commits into from
Oct 21, 2022

Conversation

abhinav-nath
Copy link
Contributor

Signed-off-by: Abhinav Nath abhinavnath@ymail.com

Description

Add support to parse sub-aggregations from filter/nested aggregations.

Issues Resolved

Link

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@abhinav-nath abhinav-nath requested review from a team and madhusudhankonda as code owners October 7, 2022 09:16
@abhinav-nath abhinav-nath mentioned this pull request Oct 7, 2022
Closed
dblock
dblock approved these changes Oct 11, 2022
View reviewed changes
Copy link
Member

@dblock dblock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder whether we'd be better off separating the classes across tests. In this change Product serves multiple tests, so eventually it becomes a mess, doesn't it?

dblock
dblock requested changes Oct 11, 2022
View reviewed changes
Copy link
Member

@dblock dblock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We really need a USER_GUIDE similar to https://github.com/opensearch-project/opensearch-js/blob/main/USER_GUIDE.md here. Would you mind starting that as part of this PR with just documenting aggregations?

@abhinav-nath
Copy link
Contributor Author

We really need a USER_GUIDE similar to https://github.com/opensearch-project/opensearch-js/blob/main/USER_GUIDE.md here. Would you mind starting that as part of this PR with just documenting aggregations?

Sorry, was busy with work. I have added a USER_GUIDE.md with most of the basic operations (including aggregations). Please review and approve the PR now.

dblock
dblock previously approved these changes Oct 20, 2022
View reviewed changes
Copy link
Member

@dblock dblock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks! Let's add a link to USER_GUIDE from README as well. Doesn't have to block this PR.

@abhinav-nath
Copy link
Contributor Author

Looks great, thanks! Let's add a link to USER_GUIDE from README as well. Doesn't have to block this PR.

I have added the link to USER_GUIDE in the README.

@abhinav-nath
Copy link
Contributor Author

Looks great, thanks! Let's add a link to USER_GUIDE from README as well. Doesn't have to block this PR.

I have added the link to USER_GUIDE in the README.

@dblock Can we please merge this PR now? I really need it for a project. Thanks.

dblock
dblock requested changes Oct 20, 2022
View reviewed changes
Copy link
Member

@dblock dblock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The CHANGELOG verifier is complaining, need to add a line to that. Sorry about that ;(

README.md Outdated Show resolved Hide resolved
abhinav-nath and others added 15 commits October 21, 2022 13:08
@abhinav-nath
Add support to parse sub-aggregations from filter/nested aggregations
47c7248 
Signed-off-by: Abhinav Nath <abhinavnath@ymail.com>
@abhinav-nath
Add USER_GUIDE.md
e7107c9 
Signed-off-by: Abhinav Nath <abhinavnath@ymail.com>
@abhinav-nath
Add DCO
58cc30d 
Signed-off-by: Abhinav Nath <abhinavnath@ymail.com>
@abhinav-nath
Add link to USER_GUIDE.md in README.md
4c613a5 
Signed-off-by: Abhinav Nath <abhinavnath@ymail.com>
@harshavamsi @abhinav-nath
Add changelog and changelog verifier (opensearch-project#239)
1d7074f 
Signed-off-by: Harsha Vamsi Kalluri <harshavamsi096@gmail.com>

Signed-off-by: Harsha Vamsi Kalluri <harshavamsi096@gmail.com>
Signed-off-by: Abhinav Nath <abhinavnath@ymail.com>
@meetesh @abhinav-nath
Set javadoc encoding to utf-8 (opensearch-project#50) (opensearch-pro…
ee7ed8f 
…ject#241)

Signed-off-by: Meetesh Kumawat<kmeetesh@gmail.com>
Signed-off-by: meetesh <kmeetesh@gmail.com>

Signed-off-by: Meetesh Kumawat<kmeetesh@gmail.com>
Signed-off-by: meetesh <kmeetesh@gmail.com>
Signed-off-by: Abhinav Nath <abhinavnath@ymail.com>
@reta @abhinav-nath
Update Jackson Databind to 2.13.4.2 (addressing CVE-2022-42003) (open…
ff30174 
…search-project#240)

Signed-off-by: Andriy Redko <andriy.redko@aiven.io>

Signed-off-by: Andriy Redko <andriy.redko@aiven.io>
Signed-off-by: Abhinav Nath <abhinavnath@ymail.com>
@harshavamsi @abhinav-nath
Updates changelog for dependabot PRs (opensearch-project#247)
bac2e41 
* Updates changelog for dependabot PRs

Signed-off-by: Harsha Vamsi Kalluri <harshavamsi096@gmail.com>

* Adding dependabot label for workflow

Signed-off-by: Harsha Vamsi Kalluri <harshavamsi096@gmail.com>

Signed-off-by: Harsha Vamsi Kalluri <harshavamsi096@gmail.com>
Signed-off-by: Abhinav Nath <abhinavnath@ymail.com>
@reta @abhinav-nath
Update tests to use JUnit's Assert (opensearch-project#244)
9f1e54b 
Signed-off-by: Andriy Redko <andriy.redko@aiven.io>

Signed-off-by: Andriy Redko <andriy.redko@aiven.io>
Signed-off-by: Abhinav Nath <abhinavnath@ymail.com>
@harshavamsi @dblock @abhinav-nath
Update literature around changelog (opensearch-project#242)
da20ae5 
* Update literature

Signed-off-by: Harsha Vamsi Kalluri <harshavamsi096@gmail.com>

* Removing pr template and updating language

Signed-off-by: Harsha Vamsi Kalluri <harshavamsi096@gmail.com>

Signed-off-by: Harsha Vamsi Kalluri <harshavamsi096@gmail.com>
Co-authored-by: Daniel (dB.) Doubrovkine <dblock@amazon.com>
Signed-off-by: Abhinav Nath <abhinavnath@ymail.com>
@dependabot @abhinav-nath
Bump grgit-gradle from 4.0.1 to 5.0.0 (opensearch-project#243)
9db6c5c 
* Bump grgit-gradle from 4.0.1 to 5.0.0

Bumps [grgit-gradle](https://github.com/ajoberstar/grgit) from 4.0.1 to 5.0.0.
- [Release notes](https://github.com/ajoberstar/grgit/releases)
- [Commits](ajoberstar/grgit@4.0.1...5.0.0)

---
updated-dependencies:
- dependency-name: org.ajoberstar.grgit:grgit-gradle
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>

* Update changelog

Signed-off-by: dependabot[bot] <support@github.com>

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: dependabot[bot] <dependabot[bot]@users.noreply.github.com>
Signed-off-by: Abhinav Nath <abhinavnath@ymail.com>
@abhinav-nath
Add DCO
b94820e 
Signed-off-by: Abhinav Nath <abhinavnath@ymail.com>
@abhinav-nath
Update CHANGELOG and README
c36dbeb 
Signed-off-by: Abhinav Nath <abhinavnath@ymail.com>
@abhinav-nath
Add DCO
b0d205a 
Signed-off-by: Abhinav Nath <abhinavnath@ymail.com>
@abhinav-nath
Add DCO
4bd4a43 
Signed-off-by: Abhinav Nath <abhinavnath@ymail.com>
dblock
dblock requested changes Oct 21, 2022
View reviewed changes
Copy link
Member

@dblock dblock left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Below ;)

Btw, if you want to make your commit look nicer after I squash it on merge, you can always squash and force push on the client. This can be a little tricky, I usually create a new branch off main, merge the change and force push it over, something like this (haven't actually tried):

git checkout main
git checkout -b subaggregations-squashed
git merge subaggregations --squash
git comit -s -m ....
git push origin -f subaggregations-squashed:subaggregations

For small changes on top of my PRs I usually amend/force push. I even have an alias called git commend for it.

CHANGELOG.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
@abhinav-nath
Fix CHANGLOG and README TOC
707d6b3 
Signed-off-by: Abhinav Nath <abhinavnath@ymail.com>
VachaShah
VachaShah approved these changes Oct 21, 2022
View reviewed changes
Copy link
Collaborator

@VachaShah VachaShah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @abhinav-nath!

@VachaShah VachaShah merged commit 1ac790a into opensearch-project:main Oct 21, 2022
@abhinav-nath
Copy link
Contributor Author

Thank you. Could you please add a "HACKTOBERFEST-ACCEPTED" label to this PR? Would be great for my dev profile 😊
@dblock @VachaShah

https://hacktoberfest.com/participation/#pr-mr-details

@abhinav-nath
Copy link
Contributor Author

Thank you. Could you please add a "HACKTOBERFEST-ACCEPTED" label to this PR? Would be great for my dev profile 😊 @dblock @VachaShah

https://hacktoberfest.com/participation/#pr-mr-details

Can someone do it please?

@dblock dblock added hacktoberfest Global event that encourages people to contribute to open-source. hacktoberfest-accepted Accepted hacktoberfest contribution. labels Oct 25, 2022
@dblock
Copy link
Member

dblock commented Oct 25, 2022

Done @abhinav-nath

@abhinav-nath
Copy link
Contributor Author

Done @abhinav-nath

Thank you @dblock 🙏🏼

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@VachaShah VachaShah VachaShah approved these changes

@dblock dblock dblock approved these changes

@madhusudhankonda madhusudhankonda Awaiting requested review from madhusudhankonda madhusudhankonda is a code owner

Assignees
No one assigned
Labels
hacktoberfest Global event that encourages people to contribute to open-source. hacktoberfest-accepted Accepted hacktoberfest contribution.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@abhinav-nath @dblock @VachaShah @harshavamsi @meetesh @reta