Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] [CCI] Passing unnecessary data argument to the superclass OpenSearchClientError #420

Closed
timursaurus opened this issue Mar 8, 2023 · 0 comments · Fixed by #421
Closed

[BUG] [CCI] Passing unnecessary data argument to the superclass OpenSearchClientError #420

timursaurus opened this issue Mar 8, 2023 · 0 comments · Fixed by #421
Assignees
@timursaurus
Labels
🐛 bug Something isn't working CCI College Contributor Initiative

Comments

@timursaurus
Copy link
Collaborator

What is the bug?

Inconsistencies exist among the OpenSearchClientError subclasses, as some of them pass the unnecessary data argument when invoking the superclass, while others do not. To maintain consistency, the data argument should be removed when invoking the superclass.
Examples:

SerializationError
DeserializationError

What is the expected behavior?

The data argument should not be passed when invoking the superclass, as is the case with other subclasses.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@timursaurus timursaurus

Labels
🐛 bug Something isn't working CCI College Contributor Initiative
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[CCI] Refactor: Remove unnecessary data argument when invoking OpenSearchClientError
3 participants
@nhtruong @wbeckler @timursaurus