Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CCI] Refactor: Remove unnecessary data argument when invoking OpenSearchClientError #421

Merged
merged 5 commits into from
Mar 8, 2023
Merged

[CCI] Refactor: Remove unnecessary data argument when invoking OpenSearchClientError #421

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
3ee8e1b
feat: overload constructor to SerializationError class
timursaurus Mar 8, 2023
2344d7e
refactor: remove unnecessary data argument
timursaurus Mar 8, 2023
15912e3
fix: remove overload
timursaurus Mar 8, 2023
12bc893
chore: update changelog
timursaurus Mar 8, 2023
094b8ac
fix: link to PR
timursaurus Mar 8, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,6 +39,7 @@ Inspired from [Keep a Changelog](https://keepachangelog.com/en/1.0.0/)
- Documented all API methods ([#335](https://github.com/opensearch-project/opensearch-js/issues/335))
- Added point in time APIs ([#348](https://github.com/opensearch-project/opensearch-js/pull/348))
- Added support for Amazon OpenSearch Serverless ([#356](https://github.com/opensearch-project/opensearch-js/issues/356))
- Removed unnecessary `data` argument when invoking `OpenSearchClientError` ([#421](https://github.com/opensearch-project/opensearch-js/pull/421))

### Dependencies
- Bumps `xmlbuilder2` from 2.4.1 to 3.0.2
Expand Down
4 changes: 2 additions & 2 deletions lib/errors.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,7 +70,7 @@ class NoLivingConnectionsError extends OpenSearchClientError {

class SerializationError extends OpenSearchClientError {
constructor(message, data) {
super(message, data);
super(message);
Error.captureStackTrace(this, SerializationError);
this.name = 'SerializationError';
this.message = message || 'Serialization Error';
Expand All @@ -80,7 +80,7 @@ class SerializationError extends OpenSearchClientError {

class DeserializationError extends OpenSearchClientError {
constructor(message, data) {
super(message, data);
super(message);
Error.captureStackTrace(this, DeserializationError);
this.name = 'DeserializationError';
this.message = message || 'Deserialization Error';
Expand Down