Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

testDocumentGenerator fetches endpoint and auth from config file #1300

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

jugal-chauhan
Copy link
Collaborator

@jugal-chauhan jugal-chauhan commented Feb 18, 2025

Description

This change eliminates the need to manually provide endpoint and authentication details. The script now fetches these details from the migration-services.yaml file. It also leverages boto3 to obtain AWS session credentials from within the migration console, improving security and ease of use.

Testing

flake8
./gradlew test
./gradlew spotlessCheck
./gradlew spotlessApply

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Jugal Chauhan <jugaldc@amazon.com>
Copy link

codecov bot commented Feb 18, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79.79%. Comparing base (a96eda1) to head (7bd5db2).
Report is 27 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #1300      +/-   ##
============================================
+ Coverage     79.32%   79.79%   +0.46%     
- Complexity     3181     3231      +50     
============================================
  Files           438      440       +2     
  Lines         16400    17034     +634     
  Branches       1114     1153      +39     
============================================
+ Hits          13010    13592     +582     
- Misses         2712     2773      +61     
+ Partials        678      669       -9     
Flag Coverage Δ
unittests 79.79% <ø> (+0.46%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Jugal Chauhan <jugaldc@amazon.com>
Signed-off-by: Jugal Chauhan <jugaldc@amazon.com>
Copy link
Collaborator

@lewijacn lewijacn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for changes

@jugal-chauhan jugal-chauhan changed the title Update testDocumentGenerator script with YAML config and boto3 auth testDocumentGenerator fetches endpoint and auth from config file Feb 24, 2025
Signed-off-by: Jugal Chauhan <jugaldc@amazon.com>
@mikaylathompson mikaylathompson self-requested a review February 26, 2025 15:55
Signed-off-by: Jugal Chauhan <jugaldc@amazon.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants