-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
testDocumentGenerator fetches endpoint and auth from config file #1300
base: main
Are you sure you want to change the base?
Conversation
b96546f
to
81a6770
Compare
Signed-off-by: Jugal Chauhan <jugaldc@amazon.com>
81a6770
to
697ff9c
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1300 +/- ##
============================================
+ Coverage 79.32% 79.79% +0.46%
- Complexity 3181 3231 +50
============================================
Files 438 440 +2
Lines 16400 17034 +634
Branches 1114 1153 +39
============================================
+ Hits 13010 13592 +582
- Misses 2712 2773 +61
+ Partials 678 669 -9
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
TrafficCapture/dockerSolution/src/main/docker/elasticsearchTestConsole/testDocumentGenerator.py
Outdated
Show resolved
Hide resolved
TrafficCapture/dockerSolution/src/main/docker/elasticsearchTestConsole/testDocumentGenerator.py
Outdated
Show resolved
Hide resolved
TrafficCapture/dockerSolution/src/main/docker/elasticsearchTestConsole/testDocumentGenerator.py
Show resolved
Hide resolved
TrafficCapture/dockerSolution/src/main/docker/elasticsearchTestConsole/testDocumentGenerator.py
Outdated
Show resolved
Hide resolved
Signed-off-by: Jugal Chauhan <jugaldc@amazon.com>
cabf7ee
to
0474fbb
Compare
TrafficCapture/dockerSolution/src/main/docker/elasticsearchTestConsole/testDocumentGenerator.py
Outdated
Show resolved
Hide resolved
TrafficCapture/dockerSolution/src/main/docker/elasticsearchTestConsole/testDocumentGenerator.py
Show resolved
Hide resolved
Signed-off-by: Jugal Chauhan <jugaldc@amazon.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for changes
TrafficCapture/dockerSolution/src/main/docker/elasticsearchTestConsole/testDocumentGenerator.py
Outdated
Show resolved
Hide resolved
Signed-off-by: Jugal Chauhan <jugaldc@amazon.com>
TrafficCapture/dockerSolution/src/main/docker/elasticsearchTestConsole/testDocumentGenerator.py
Outdated
Show resolved
Hide resolved
TrafficCapture/dockerSolution/src/main/docker/elasticsearchTestConsole/testDocumentGenerator.py
Outdated
Show resolved
Hide resolved
Signed-off-by: Jugal Chauhan <jugaldc@amazon.com>
8645d33
to
7bd5db2
Compare
Description
This change eliminates the need to manually provide endpoint and authentication details. The script now fetches these details from the
migration-services.yaml
file. It also leveragesboto3
to obtain AWS session credentials from within the migration console, improving security and ease of use.Testing
flake8
./gradlew test
./gradlew spotlessCheck
./gradlew spotlessApply
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.