[K8s] Generate migration_services.yaml from ConfigMaps #1307
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Tanner Lewis <lewijacn@amazon.com>
Signed-off-by: Tanner Lewis <lewijacn@amazon.com>
Signed-off-by: Tanner Lewis <lewijacn@amazon.com>
… container to main container Signed-off-by: Tanner Lewis <lewijacn@amazon.com>
Signed-off-by: Tanner Lewis <lewijacn@amazon.com>
Signed-off-by: Tanner Lewis <lewijacn@amazon.com>
Signed-off-by: Tanner Lewis <lewijacn@amazon.com>
Signed-off-by: Tanner Lewis <lewijacn@amazon.com>
Signed-off-by: Tanner Lewis <lewijacn@amazon.com>
Signed-off-by: Tanner Lewis <lewijacn@amazon.com>
Signed-off-by: Tanner Lewis <lewijacn@amazon.com>
# Conflicts: # TrafficCapture/dockerSolution/src/main/docker/migrationConsole/Dockerfile # deployment/k8s/charts/aggregates/migrationAssistant/values.yaml # deployment/k8s/charts/components/migrationConsole/migration_services.yaml # deployment/k8s/charts/components/migrationConsole/templates/deployment.yaml # deployment/k8s/minikubeLocal.sh # deployment/k8s/update_deps.sh
lewijacn
temporarily deployed
to
migrations-cicd
GitHub Actions
Inactive
Signed-off-by: Tanner Lewis <lewijacn@amazon.com>
lewijacn
temporarily deployed
to
migrations-cicd
GitHub Actions
Inactive
Signed-off-by: Tanner Lewis <lewijacn@amazon.com>
lewijacn
temporarily deployed
to
migrations-cicd
GitHub Actions
Inactive
Signed-off-by: Tanner Lewis <lewijacn@amazon.com>
lewijacn
temporarily deployed
to
migrations-cicd
GitHub Actions
Inactive
Signed-off-by: Tanner Lewis <lewijacn@amazon.com>
lewijacn
temporarily deployed
to
migrations-cicd
GitHub Actions
Inactive
Signed-off-by: Tanner Lewis <lewijacn@amazon.com>
lewijacn
had a problem deploying
to
migrations-cicd
GitHub Actions
Failure
Signed-off-by: Tanner Lewis <lewijacn@amazon.com>
lewijacn
temporarily deployed
to
migrations-cicd
GitHub Actions
Inactive
Signed-off-by: Tanner Lewis <lewijacn@amazon.com>
lewijacn
temporarily deployed
to
migrations-cicd
GitHub Actions
Inactive
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1307 +/- ##
============================================
- Coverage 79.36% 79.33% -0.04%
- Complexity 3184 3196 +12
============================================
Files 438 444 +6
Lines 16403 16874 +471
Branches 1114 1117 +3
============================================
+ Hits 13019 13387 +368
- Misses 2709 2814 +105
+ Partials 675 673 -2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
lewijacn
requested review from
chelma,
gregschohn,
mikaylathompson,
peternied,
sumobrian and
jugal-chauhan
as code owners
Signed-off-by: Tanner Lewis <lewijacn@amazon.com>
lewijacn
temporarily deployed
to
migrations-cicd
GitHub Actions
Inactive
peternied
reviewed
Feb 26, 2025
|
|
||
| [report] | ||
| omit = | ||
| */tests/* |
There was a problem hiding this comment.
Nit: I like seeing test coverage information, makes it really clear when tests are disabled or we've got extraneous logic that should be reviewed
| @@ -248,6 +249,7 @@ jobs: | |||
| --exclude "https://localhost*" | |||
| --exclude "http://capture-proxy*" | |||
| --exclude "https://capture-proxy*" | |||
| --exclude-path "TrafficCapture/dockerSolution/src/main/docker/k8sConfigMapUtilScripts/tests/data" | |||
There was a problem hiding this comment.
Could we instead add the k8 urls that are common to the project like the above that we have so we can be sure we are using valid urls save for really specific items?
| @@ -0,0 +1,33 @@ | |||
| # Kubernetes Config Map Utility Library | |||
|
|
|||
| This library provides utilities for working with Kubernetes ConfigMaps and specifically generating a `migration_services.yaml` usable by the Migration Console from ConfigMap values | |||
There was a problem hiding this comment.
Could you provide more details on where/how those ConfigMap values are set?
| @@ -0,0 +1,33 @@ | |||
| # Kubernetes Config Map Utility Library | |||
|
|
|||
There was a problem hiding this comment.
Whats the lifecycle of this tool, it looks like it should be turned on and it watches for changes, or should it be triggered on /off by something?
| @@ -23,17 +23,17 @@ start() { | |||
| helm repo add strimzi https://strimzi.io/charts/ | |||
|
|
|||
| minikube start | |||
| minikube mount .:/opensearch-migrations > /dev/null 2>&1 & | |||
| #minikube mount .:/opensearch-migrations > /dev/null 2>&1 & | |||
There was a problem hiding this comment.
Remove these commented out lines?
| condition: conditionalPackageInstalls.jaeger | ||
| version: "3.2.0" | ||
| repository: "https://jaegertracing.github.io/helm-charts" | ||
| # - name: grafana |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This change removes the static
migration_services.yamlwe were using temporarily for K8s to now utilize the groundwork we had in the K8s config map utils library for generating this file from ConfigMap values.Note: While several attempts were made to keep the existing
/etc/migration_services.yamlpath on the Migration Console container, K8s does not seem to make it easy to mount only a single file like was done with the Docker compose setup, but rather requires a good bit of misdirection which I didn't want to cause more complexity here. The new path that is utilized here is/config/migration_services.yamlwith the entire config directory being mounted on the Migration Console container.Issues Resolved
https://opensearch.atlassian.net/browse/MIGRATIONS-2383
Testing
Python unit tests
Local K8s testing
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.