Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generating Endpoints from OpenSearch API Specification #193

Closed
wants to merge 6 commits into from

Conversation

saimedhi
Copy link
Collaborator

Description

Generating Endpoints from OpenSearch API Specification

Issues Resolved

Related to #97

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Sai Medhini Reddy Maryada and others added 4 commits April 14, 2024 20:09
Signed-off-by: saimedhi <saimedhi@amazon.com>
Signed-off-by: saimedhi <saimedhi@amazon.com>
@saimedhi saimedhi marked this pull request as draft May 22, 2024 17:51
@dblock
Copy link
Member

dblock commented May 22, 2024

(Summarizing a discussion we had offline.)

  1. Make this PR just the generator (remove the generated files so we can just review the generator code changes).
  2. Make a separate PR with a GitHub workflow that automatically runs the generator and makes PRs for the changes.

Iterate on the generator incrementally (1) until (2) can be merged without breaking anything in the client. Then we merge (2).

@saimedhi
Copy link
Collaborator Author

Closing this PR as suggested.

@saimedhi saimedhi closed this May 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants