Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generated Endpoints Using OpenSearch API Specifications: Phase II #206

Merged
merged 1 commit into from
Jul 9, 2024

Conversation

saimedhi
Copy link
Collaborator

@saimedhi saimedhi commented Jul 8, 2024

Description

Generated Endpoints Using OpenSearch API Specifications: Phase II

Issues Resolved

Closes #97

Generated code

  • Except for minor corrections to the generator and tests, all endpoint and namespace code is generated. I have verified the accuracy of the generation.

  • Below are the changes observed:

    • UpdateByQuery- Param removed - version_type
    • Create- path param id is required now. Wrote patch to direct to Index endpoint when id is not given.
    • CreatePointInTime is replaced by CreatePit. Backward compatible.
    • DeletePointInTime is replaced by DeletePit. Backward compatible.
    • cat.Help- Params removed - help, s
    • cat.Transforms- Endpoint removed - verified, path not present in server code.
    • indices.Freeze- Endpoint removed - verified, path not present in server code.
    • indices.Unfreeze- Endpoint removed - verified, path not present in server code.
    • indices.ReloadSearchAnalyzers- Endpoint removed - verified, path not present in server code.
  • Will raise followup PR for security and MachineLearning Namespaces

  • In the followup PR, will make autogenerated file indication more clear, including details of how to run generator.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: saimedhi <saimedhi@amazon.com>
@saimedhi saimedhi force-pushed the generated-code-phase2 branch from 85e203d to 782242f Compare July 8, 2024 22:58
@saimedhi
Copy link
Collaborator Author

saimedhi commented Jul 9, 2024

@dblock, Please take a look. Thank you.

Copy link
Member

@dblock dblock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@dblock dblock merged commit fc749ea into opensearch-project:main Jul 9, 2024
45 of 46 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEATURE] New API Client generated from spec
2 participants