feat(AsyncOpenSearch): consistent pool_maxsize setting #845
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: samypr100 <3933065+samypr100@users.noreply.github.com>
samypr100
force-pushed
the
async-pool-maxsize
branch
from
5c27c47 to
37e360d
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #845 +/- ##
==========================================
- Coverage 71.95% 70.92% -1.04%
==========================================
Files 91 113 +22
Lines 8001 8900 +899
==========================================
+ Hits 5757 6312 +555
- Misses 2244 2588 +344 ☔ View full report in Codecov by Sentry. |
samypr100
commented
Nov 12, 2024
There was a problem hiding this comment.
This uses the same testing structure as test_urllib3.py and test_requests.py for consistency. Happy to make changes / move it.
samypr100
requested review from
VachaShah,
dblock,
harshavamsi,
axeoman,
Shephalimittal,
saimedhi and
florianvazelle
as code owners
|
Thanks for fixing this. In general I think we need a way to make these options and tests share a lot more code. There's a constant stream of bugs where something works/exists in sync and doesn't in async. Maybe someone (wink wink) has good ideas and wants to try and refactor things :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Allows using
pool_maxsizein AsyncOpenSearch client to align with OpenSearch client.Issues Resolved
Closes #844
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.