Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix incorrect variable name #247

Merged
merged 6 commits into from
Apr 25, 2024
Merged

Fix incorrect variable name #247

merged 6 commits into from
Apr 25, 2024

Conversation

mlarraz
Copy link
Contributor

@mlarraz mlarraz commented Apr 16, 2024

Description

This appears to be a typo that causes error when #respond_to? is called on either of these objects.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Matt Larraz <mlarraz@users.noreply.github.com>
dblock

This comment was marked as duplicate.

Copy link
Member

@dblock dblock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like it! Care to write a unit test please?

@mlarraz
Copy link
Contributor Author

mlarraz commented Apr 17, 2024

Looks like it! Care to write a unit test please?

Any guidance on which file to put it in?

@nhtruong
Copy link
Collaborator

There's currently no unit tests for this yet. If you're to add one, it should be in ./spec/opensearch/client/unit. Something like:

require_relative '../../../spec_helper'

describe 'OpenSearch::Client#respond_to_missing?' do
  it 'returns to correct results' do
    client = OpenSearch::Client.new
    expect(client.send(:respond_to_missing?, :perform_request)).to be true
    expect(client.send(:respond_to_missing?, :something_else)).to be false
  end
end

Signed-off-by: Theo Truong <theotr@amazon.com>
Signed-off-by: Theo Truong <theotr@amazon.com>
@nhtruong
Copy link
Collaborator

@mlarraz I've created a PR into your branch: https://github.com/mlarraz/opensearch-ruby/pull/1/files

mlarraz and others added 2 commits April 23, 2024 22:03
@nhtruong
Copy link
Collaborator

@nhtruong
Copy link
Collaborator

@dblock Would you mind adding your review? I have commits in this PR so my review doesn't count.

@VachaShah VachaShah requested a review from dblock April 25, 2024 16:18
@dblock
Copy link
Member

dblock commented Apr 25, 2024

Should we change the number of approvers like in opensearch-project/opensearch-php#179? If you agree open an issue and I'll vote yes @nhtruong? :)

@dblock dblock merged commit 096fbde into opensearch-project:main Apr 25, 2024
59 checks passed
@nhtruong
Copy link
Collaborator

@dblock I thought this one only needed 1 approver. Let's do that like other small repos we have.

@dblock
Copy link
Member

dblock commented Apr 25, 2024

@nhtruong You're right, not sure what I was seeing, maybe an unresolved conversation or smth... ignore me.

@nhtruong
Copy link
Collaborator

I saw unresolved request too but didn't see any option to resolve your comment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants