-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FEATURE] Create OpenSearchClient implementation in SDK Client and deprecate it #302
Comments
Existing plugin implementations use this signature: protected RestChannelConsumer prepareRequest(RestRequest request, NodeClient client) throws IOException { ... } Proposed implementation:
|
I created SDKNodeClient and created a dummy API in AD Extension to get it working but was facing issue with initialization of NodeClient.
|
I don't think that's such a simple replacement. So whatever client we create still has to pass the action identifier, and the request, to be executed by another class. |
I believe what is necessary for step 3 above is to use a
|
Looking further into this:
|
Raised a draft PR for @dbwiddis POC work for converting AD plugin to AD Extension using High Level Rest Client: opensearch-project/anomaly-detection#773 |
Is your feature request related to a problem?
To speed migration work for AD Plugin (and other existing plugins) we will create a client that can use the existing (NodeClient) API calls from those plugins.
What solution would you like?
Create a new getter in SDKClient that returns an instance Implementing OpenSearchClient that can be used by REST Handlers. Add deprecation annotations and javadocs clearly stating that it is provided for backwards compatibility and will eventually be removed.
What alternatives have you considered?
See #294
Do you have any additional context?
See opensearch-project/OpenSearch#5424 regarding eventual deprecation.
The text was updated successfully, but these errors were encountered: