Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate Stop Detector job to SDK using SDKRestClient #384

Closed
1 task
Tracked by #5224
dbwiddis opened this issue Jan 29, 2023 · 2 comments
Closed
1 task
Tracked by #5224

Migrate Stop Detector job to SDK using SDKRestClient #384

dbwiddis opened this issue Jan 29, 2023 · 2 comments
Assignees
Labels
enhancement New feature or request

Comments

@dbwiddis
Copy link
Member

Is your feature request related to a problem?

Part of opensearch-project/OpenSearch#5224

What solution would you like?

Migrate the Stop Detector job Rest API to Extensions SDK using SDKRestClient.

Use the implementation of #353 as a reference. Add new issues for any steps you skip.

Implement the following API endpoints:

  • POST _plugins/_anomaly_detection/detectors/<detectorId>/_stop
@joshpalis
Copy link
Member

joshpalis commented Mar 23, 2023

Completed Tasks:

  • Modify StopDetectorTransportAction to extend directly from TransportAction and register within getActions
  • Replace client/cluster service with corresponding SDK classes, refactor OpenSearch action invocations with corresponding OpenSearchAsyncClient methods (if any) and register required created components to inject into DeleteModelTransportAction
    • SearchFeatureDao
    • NodeStateManager
    • FeatureManager
    • CheckpointDao
    • CheckpointWriteWorker
    • EntityColdStarter
    • ModelManager
  • Fix affected test classes

Remaining Tasks:

  • Return CacheProvider as part of createComponents for use in DeleteModelTransportAction
  • Modify DeleteModelTransportAction to extend directly from TransportAction rather than from TransportNodeAction and register within getActions. This is invoked by StopDetectorTransportAction
  • Fix MultiEntityResultTests

Note : This is dependent on StartDetector

@minalsha
Copy link
Collaborator

@joshpalis I see PR for stop detector:opensearch-project/anomaly-detection#845 merged. Can we close this issue?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

4 participants