Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE] Initialize SDKClient with instance of ExtensionSettings #556

Closed
dbwiddis opened this issue Mar 13, 2023 · 4 comments
Closed

[FEATURE] Initialize SDKClient with instance of ExtensionSettings #556

dbwiddis opened this issue Mar 13, 2023 · 4 comments
Assignees
Labels
CCI Part of the College Contributor Initiative enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed

Comments

@dbwiddis
Copy link
Member

dbwiddis commented Mar 13, 2023

Is your feature request related to a problem?

The SDKClient constructor takes no arguments.

This requires either a host address and port, or the ExtensionSettings, to be passed via parameters to initialize other clients. This client is only ever instantiated once, and we have a copy of the ExtensionSettings when we do so.

What solution would you like?

  1. Add a parameter to the SDKClient constructor taking an instance of ExtensionSettings and saving it as an instance field
  2. Use that instance field to either replace (my preference) or overload (I won't complain) initializeJavaClient(ExtensionSettings settings), initializeJavaAsyncClient(ExtensionSettings settings) and initializeRestClient(ExtensionSettings settings).

What alternatives have you considered?

Status quo.

@dbwiddis dbwiddis added enhancement New feature or request untriaged good first issue Good for newcomers help wanted Extra attention is needed and removed untriaged labels Mar 13, 2023
@Kuanysh-kst
Copy link
Contributor

Hello @dbwiddis, I would like to take this issue

@dbwiddis
Copy link
Member Author

All yours, @Kuanysh-kst ... note there's an Open PR #558 you'll want to let get merged and sync with main before you start. Hopefully that'll happen later today.

@Kuanysh-kst
Copy link
Contributor

#579

@dbwiddis dbwiddis added the CCI Part of the College Contributor Initiative label Mar 24, 2023
@dbwiddis
Copy link
Member Author

dbwiddis commented Apr 9, 2023

Fixed in #579

@dbwiddis dbwiddis closed this as completed Apr 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CCI Part of the College Contributor Initiative enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants