Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE] Add getExecutorBuilders extension point to SDK BaseExtension interface #624

Closed
joshpalis opened this issue Mar 29, 2023 · 0 comments
Assignees
Labels
enhancement New feature or request

Comments

@joshpalis
Copy link
Member

Is your feature request related to a problem?

In the AnomalyDetectorJobRunner, when the job runner's runJob() method is invoked by Job Scheduler, AD creates a Runnable here that executes the job when invoked. The runnable is then submitted to this threadpool executor here for the threadpool named ad-threadpool.

The executor builder for this particular threadpool is instantiated here within the getExecutorBuilders extension point.

Within node.java, the executor builders for each plugin is retrieved here, which is then used to instantiate the threadpool here.

What solution would you like?

The SDK's BaseExtension interface should have a method called getExecutorBuilders in which we return a list of ExecutorBuilders from an extension. These executor builders should then be retrieved from the extension during ExtensionsRunner initialization and used to instantiate the threadpool here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants