Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement TransportNodesAction equivalent for SDK #683

Open
4 tasks
Tracked by #720
vibrantvarun opened this issue Apr 14, 2023 · 1 comment
Open
4 tasks
Tracked by #720

Implement TransportNodesAction equivalent for SDK #683

vibrantvarun opened this issue Apr 14, 2023 · 1 comment
Labels
enhancement New feature or request

Comments

@vibrantvarun
Copy link
Member

vibrantvarun commented Apr 14, 2023

Is your feature request related to a problem?

TransportNodesAction is an abstract class in OpenSearch. This class is been inherited by many transportActions in the AnomalyDetector plugin. It accepts 4 parameters mentioned below.

  1. NodesRequest extends BaseNodesRequest,
  2. NodesResponse extends BaseNodesResponse,
  3. NodeRequest extends TransportRequest,
  4. NodeResponse extends BaseNodeResponse

For extensions, we need to extend TransportAction abstract class in all classes which has transportAPI code in AD.
TransportAction accepts 2 parameters

  1. Request extends ActionRequest,
  2. Response extends ActionResponse

Therefore, there is a need to make TransportNodesAction equivalent for SDK as well.

What solution would you like?

The issue requires us to

  • Cater all the classes which extend TransportNodesAction.
  • Create a TransportNodesAction for SDK and implement the same level of functionality which it currently has.
  • Test the Sanity of the API's for extensions and compare there response with plugins
  • Document the changes
@vibrantvarun vibrantvarun added enhancement New feature or request untriaged labels Apr 14, 2023
@dbwiddis
Copy link
Member

Key point here is this class of requests are intended to query information on multiple OpenSearch nodes. In the Extension enviornment we don't have all those nodes present so we would need to (possibly?) query the information via some REST API equivalent. Classic example may be a NodesStatsRequest to get Indexing pressure (see #655).

So we may want to create a local SDK transport action that queries OpenSearch via REST API for data like this. A general abstract superclass will allow for other similar requests to node stats.

@owaiskazi19 owaiskazi19 changed the title [Feature/Extensions] Implement TransportNodesAction equivalent for SDK Implement TransportNodesAction equivalent for SDK May 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants