Integrated Async Java Client #558
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Owais Kazi <owaiskazi19@gmail.com>
owaiskazi19
requested review from
joshpalis,
ryanbogan,
saratvemulapalli and
dbwiddis
as code owners
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #558 +/- ##
============================================
+ Coverage 67.67% 67.89% +0.22%
- Complexity 200 203 +3
============================================
Files 36 36
Lines 863 869 +6
Branches 26 26
============================================
+ Hits 584 590 +6
Misses 269 269
Partials 10 10 ☔ View full report in Codecov by Sentry. |
dbwiddis
requested changes
Mar 13, 2023
Signed-off-by: Owais Kazi <owaiskazi19@gmail.com>
Signed-off-by: Owais Kazi <owaiskazi19@gmail.com>
dbwiddis
approved these changes
Mar 14, 2023
ryanbogan
approved these changes
Mar 14, 2023
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Mar 14, 2023
* Integrated Async Java Client Signed-off-by: Owais Kazi <owaiskazi19@gmail.com> * Correct ordering of method Signed-off-by: Owais Kazi <owaiskazi19@gmail.com> * Updated method name Signed-off-by: Owais Kazi <owaiskazi19@gmail.com> --------- Signed-off-by: Owais Kazi <owaiskazi19@gmail.com> (cherry picked from commit 8e0b1f6) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
ryanbogan
pushed a commit
that referenced
this pull request
Mar 14, 2023
* Integrated Async Java Client * Correct ordering of method * Updated method name --------- (cherry picked from commit 8e0b1f6) Signed-off-by: Owais Kazi <owaiskazi19@gmail.com> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
kokibas
pushed a commit
to kokibas/opensearch-sdk-java
that referenced
this pull request
Mar 15, 2023
* Integrated Async Java Client Signed-off-by: Owais Kazi <owaiskazi19@gmail.com> * Correct ordering of method Signed-off-by: Owais Kazi <owaiskazi19@gmail.com> * Updated method name Signed-off-by: Owais Kazi <owaiskazi19@gmail.com> --------- Signed-off-by: Owais Kazi <owaiskazi19@gmail.com> Signed-off-by: Nurym <nurym0807@gmail.com>
kokibas
pushed a commit
to kokibas/opensearch-sdk-java
that referenced
this pull request
Mar 16, 2023
* Integrated Async Java Client Signed-off-by: Owais Kazi <owaiskazi19@gmail.com> * Correct ordering of method Signed-off-by: Owais Kazi <owaiskazi19@gmail.com> * Updated method name Signed-off-by: Owais Kazi <owaiskazi19@gmail.com> --------- Signed-off-by: Owais Kazi <owaiskazi19@gmail.com> Signed-off-by: Nurym <nurym0807@gmail.com>
kokibas
pushed a commit
to kokibas/opensearch-sdk-java
that referenced
this pull request
Mar 17, 2023
* Integrated Async Java Client Signed-off-by: Owais Kazi <owaiskazi19@gmail.com> * Correct ordering of method Signed-off-by: Owais Kazi <owaiskazi19@gmail.com> * Updated method name Signed-off-by: Owais Kazi <owaiskazi19@gmail.com> --------- Signed-off-by: Owais Kazi <owaiskazi19@gmail.com>
Kuanysh-kst
pushed a commit
to Kuanysh-kst/opensearch-sdk-java
that referenced
this pull request
Mar 18, 2023
* Integrated Async Java Client Signed-off-by: Owais Kazi <owaiskazi19@gmail.com> * Correct ordering of method Signed-off-by: Owais Kazi <owaiskazi19@gmail.com> * Updated method name Signed-off-by: Owais Kazi <owaiskazi19@gmail.com> --------- Signed-off-by: Owais Kazi <owaiskazi19@gmail.com> Signed-off-by: Kuanysh <kuanysh4646@gmail.com>
kokibas
pushed a commit
to kokibas/opensearch-sdk-java
that referenced
this pull request
Mar 19, 2023
* Integrated Async Java Client Signed-off-by: Owais Kazi <owaiskazi19@gmail.com> * Correct ordering of method Signed-off-by: Owais Kazi <owaiskazi19@gmail.com> * Updated method name Signed-off-by: Owais Kazi <owaiskazi19@gmail.com> --------- Signed-off-by: Owais Kazi <owaiskazi19@gmail.com> Signed-off-by: Nurym <nurym0807@gmail.com>
kokibas
pushed a commit
to kokibas/opensearch-sdk-java
that referenced
this pull request
Mar 22, 2023
* Integrated Async Java Client Signed-off-by: Owais Kazi <owaiskazi19@gmail.com> * Correct ordering of method Signed-off-by: Owais Kazi <owaiskazi19@gmail.com> * Updated method name Signed-off-by: Owais Kazi <owaiskazi19@gmail.com> --------- Signed-off-by: Owais Kazi <owaiskazi19@gmail.com> Signed-off-by: Nurym <nurym0807@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
To invoke the Actions residing in OpenSearch. Extensions will use Java Client to call the action using REST requests available. Currently, we support synchronous Java Client. As AD plugin uses asynchronous request calls, create an async Java Client for the same.
This is needed for the migration of Start Detector.
Issues Resolved
Fixes #557
Fixes #296
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.