Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds getExecutorBuilders and indexNameExpressionResolver to extensionsRunner #627

Merged
merged 4 commits into from
Mar 30, 2023

Conversation

joshpalis
Copy link
Member

Description

implements the getExecutorBuilders extension point within ExtensionsRunner and also adds the indexNameExpressionResolver to the extensionRunner to be used in createComponents

The executorBuilders extension point will be implemented as part of start detector.

The indexNameExpressionResolver will be utilized as part of the AnomalyResultAction/TransportAction

Issues Resolved

#624

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

…unner and also adds the indexNameExpressionResolver to the extensionRunner to be used in createComponents

Signed-off-by: Joshua Palis <jpalis@amazon.com>
@codecov-commenter
Copy link

codecov-commenter commented Mar 30, 2023

Codecov Report

Merging #627 (0e53941) into main (e13aed8) will increase coverage by 0.16%.
The diff coverage is 100.00%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@             Coverage Diff              @@
##               main     #627      +/-   ##
============================================
+ Coverage     64.09%   64.25%   +0.16%     
- Complexity      252      253       +1     
============================================
  Files            50       50              
  Lines          1103     1108       +5     
  Branches         35       35              
============================================
+ Hits            707      712       +5     
  Misses          385      385              
  Partials         11       11              
Impacted Files Coverage Δ
...main/java/org/opensearch/sdk/ExtensionsRunner.java 77.22% <100.00%> (+0.57%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@owaiskazi19
Copy link
Member

Let's add tests for this new extension point

@joshpalis
Copy link
Member Author

@owaiskazi19 The getExecutorBuilders extension point is not new, it has been added already, this PR just utilizes the extension point within the ExtensionRunner. See some test cases here. But I will add tests for the getters that I have added

Signed-off-by: Joshua Palis <jpalis@amazon.com>
dbwiddis
dbwiddis previously approved these changes Mar 30, 2023
Copy link
Member

@dbwiddis dbwiddis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Some purely personal preference style suggestions.

ryanbogan
ryanbogan previously approved these changes Mar 30, 2023
Signed-off-by: Joshua Palis <jpalis@amazon.com>
@joshpalis joshpalis dismissed stale reviews from ryanbogan and dbwiddis via 0e53941 March 30, 2023 16:45
@joshpalis joshpalis requested review from dbwiddis and ryanbogan March 30, 2023 16:45
owaiskazi19
owaiskazi19 previously approved these changes Mar 30, 2023
Copy link
Member

@owaiskazi19 owaiskazi19 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks @joshpalis

Signed-off-by: Joshua Palis <jpalis@amazon.com>
@joshpalis joshpalis merged commit a3d94aa into opensearch-project:main Mar 30, 2023
@opensearch-trigger-bot
Copy link

The backport to 1.x failed:

The process '/usr/bin/git' failed with exit code 128

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/backport-1.x 1.x
# Navigate to the new working tree
pushd ../.worktrees/backport-1.x
# Create a new branch
git switch --create backport/backport-627-to-1.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 a3d94aa6e2191ac7bcea34e3176f6e2dcca55749
# Push it to GitHub
git push --set-upstream origin backport/backport-627-to-1.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/backport-1.x

Then, create a pull request where the base branch is 1.x and the compare/head branch is backport/backport-627-to-1.x.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants