-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds getExecutorBuilders and indexNameExpressionResolver to extensionsRunner #627
Conversation
…unner and also adds the indexNameExpressionResolver to the extensionRunner to be used in createComponents Signed-off-by: Joshua Palis <jpalis@amazon.com>
Codecov Report
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more @@ Coverage Diff @@
## main #627 +/- ##
============================================
+ Coverage 64.09% 64.25% +0.16%
- Complexity 252 253 +1
============================================
Files 50 50
Lines 1103 1108 +5
Branches 35 35
============================================
+ Hits 707 712 +5
Misses 385 385
Partials 11 11
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Let's add tests for this new extension point |
@owaiskazi19 The |
Signed-off-by: Joshua Palis <jpalis@amazon.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Some purely personal preference style suggestions.
Signed-off-by: Joshua Palis <jpalis@amazon.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thanks @joshpalis
Signed-off-by: Joshua Palis <jpalis@amazon.com>
The backport to
To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/backport-1.x 1.x
# Navigate to the new working tree
pushd ../.worktrees/backport-1.x
# Create a new branch
git switch --create backport/backport-627-to-1.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 a3d94aa6e2191ac7bcea34e3176f6e2dcca55749
# Push it to GitHub
git push --set-upstream origin backport/backport-627-to-1.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/backport-1.x Then, create a pull request where the |
Description
implements the
getExecutorBuilders
extension point withinExtensionsRunner
and also adds theindexNameExpressionResolver
to theextensionRunner
to be used increateComponents
The
executorBuilders
extension point will be implemented as part of start detector.The
indexNameExpressionResolver
will be utilized as part of the AnomalyResultAction/TransportActionIssues Resolved
#624
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.