Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add build artifacts to release #636

Merged
merged 2 commits into from
Apr 5, 2023

Conversation

BSFishy
Copy link
Contributor

@BSFishy BSFishy commented Mar 27, 2023

Description

Adds build artifacts to the release drafter workflow. By running yarn build before drafting the release, we can make sure releases include all of the compiled JS and CSS needed by consumers

Check List

  • New functionality includes testing.
  • New functionality has been documented.
  • All tests pass
    • yarn lint
    • yarn test-unit
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Matt Provost <provomat@amazon.com>
joshuarrrr
joshuarrrr previously approved these changes Mar 27, 2023
Copy link
Member

@gaiksaya gaiksaya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't have much context on how artifacts should be packed for this project. Added some comments based on what other project did.

.github/workflows/release-drafter.yml Show resolved Hide resolved
.github/workflows/release-drafter.yml Outdated Show resolved Hide resolved
Signed-off-by: Matt Provost <provomat@amazon.com>
@gaiksaya gaiksaya mentioned this pull request Apr 5, 2023
6 tasks
@BSFishy BSFishy merged commit 4c5e17d into opensearch-project:main Apr 5, 2023
opensearch-trigger-bot bot pushed a commit that referenced this pull request Apr 5, 2023
* Add build artifacts to release

Signed-off-by: Matt Provost <provomat@amazon.com>

* Wrap yarn pack into another tarball

Signed-off-by: Matt Provost <provomat@amazon.com>

---------

Signed-off-by: Matt Provost <provomat@amazon.com>
(cherry picked from commit 4c5e17d)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
opensearch-trigger-bot bot pushed a commit that referenced this pull request Apr 5, 2023
* Add build artifacts to release

Signed-off-by: Matt Provost <provomat@amazon.com>

* Wrap yarn pack into another tarball

Signed-off-by: Matt Provost <provomat@amazon.com>

---------

Signed-off-by: Matt Provost <provomat@amazon.com>
(cherry picked from commit 4c5e17d)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
joshuarrrr pushed a commit that referenced this pull request Apr 5, 2023
* Add build artifacts to release
* Wrap yarn pack into another tarball

---------


(cherry picked from commit 4c5e17d)

Signed-off-by: Matt Provost <provomat@amazon.com>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
joshuarrrr pushed a commit that referenced this pull request Apr 5, 2023
* Add build artifacts to release
* Wrap yarn pack into another tarball

---------


(cherry picked from commit 4c5e17d)

Signed-off-by: Matt Provost <provomat@amazon.com>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
SergeyMyssak pushed a commit to SergeyMyssak/oui that referenced this pull request May 10, 2023
…roject#664)

* Add build artifacts to release
* Wrap yarn pack into another tarball

---------


(cherry picked from commit 4c5e17d)

Signed-off-by: Matt Provost <provomat@amazon.com>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants