-
Notifications
You must be signed in to change notification settings - Fork 72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add build artifacts to release #636
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Matt Provost <provomat@amazon.com>
joshuarrrr
previously approved these changes
Mar 27, 2023
gaiksaya
reviewed
Mar 27, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't have much context on how artifacts should be packed for this project. Added some comments based on what other project did.
Signed-off-by: Matt Provost <provomat@amazon.com>
joshuarrrr
approved these changes
Mar 30, 2023
ashwin-pc
approved these changes
Mar 30, 2023
gaiksaya
approved these changes
Apr 5, 2023
6 tasks
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Apr 5, 2023
* Add build artifacts to release Signed-off-by: Matt Provost <provomat@amazon.com> * Wrap yarn pack into another tarball Signed-off-by: Matt Provost <provomat@amazon.com> --------- Signed-off-by: Matt Provost <provomat@amazon.com> (cherry picked from commit 4c5e17d) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Apr 5, 2023
* Add build artifacts to release Signed-off-by: Matt Provost <provomat@amazon.com> * Wrap yarn pack into another tarball Signed-off-by: Matt Provost <provomat@amazon.com> --------- Signed-off-by: Matt Provost <provomat@amazon.com> (cherry picked from commit 4c5e17d) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
joshuarrrr
pushed a commit
that referenced
this pull request
Apr 5, 2023
* Add build artifacts to release * Wrap yarn pack into another tarball --------- (cherry picked from commit 4c5e17d) Signed-off-by: Matt Provost <provomat@amazon.com> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
joshuarrrr
pushed a commit
that referenced
this pull request
Apr 5, 2023
* Add build artifacts to release * Wrap yarn pack into another tarball --------- (cherry picked from commit 4c5e17d) Signed-off-by: Matt Provost <provomat@amazon.com> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
SergeyMyssak
pushed a commit
to SergeyMyssak/oui
that referenced
this pull request
May 10, 2023
…roject#664) * Add build artifacts to release * Wrap yarn pack into another tarball --------- (cherry picked from commit 4c5e17d) Signed-off-by: Matt Provost <provomat@amazon.com> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds build artifacts to the release drafter workflow. By running
yarn build
before drafting the release, we can make sure releases include all of the compiled JS and CSS needed by consumersCheck List
yarn lint
yarn test-unit
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.