From ded8b276a977b6242363659c1163cc53891fde28 Mon Sep 17 00:00:00 2001 From: Josh Romero Date: Fri, 28 Jul 2023 18:35:23 +0000 Subject: [PATCH 1/3] Theme (Header) - update next background Signed-off-by: Josh Romero --- src/themes/oui-next/global_styling/variables/_header.scss | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/themes/oui-next/global_styling/variables/_header.scss b/src/themes/oui-next/global_styling/variables/_header.scss index 065724c403..b5fce32e85 100644 --- a/src/themes/oui-next/global_styling/variables/_header.scss +++ b/src/themes/oui-next/global_styling/variables/_header.scss @@ -10,7 +10,7 @@ */ // Themeable colors -$ouiHeaderBackgroundColor: $ouiColorEmptyShade !default; +$ouiHeaderBackgroundColor: $ouiPageBackgroundColor !default; $ouiHeaderDarkBackgroundColor: lightOrDarkTheme(shade($ouiColorDarkestShade, 28%), shade($ouiColorLightestShade, 50%)) !default; $ouiHeaderBorderColor: $ouiBorderColor !default; $ouiHeaderBreadcrumbColor: $ouiColorDarkestShade !default; From e6b95e94dd9ef56a9edaedd588b2ee6242b38736 Mon Sep 17 00:00:00 2001 From: Josh Romero Date: Fri, 28 Jul 2023 18:49:03 +0000 Subject: [PATCH 2/3] add changelog Signed-off-by: Josh Romero --- CHANGELOG.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index b99aad65a2..a888a8e896 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -11,7 +11,7 @@ ### 📈 Features/Enhancements - Rename the aliased theme files ([#863](https://github.com/opensearch-project/oui/pull/863)) - Fix `autofill` text color in dark themes ([#871](https://github.com/opensearch-project/oui/pull/871)) - +- [Header] Update background color in next theme ([#936](https://github.com/opensearch-project/oui/pull/936)) ### 🐛 Bug Fixes From e769029bcbe6aceac6dfa7c846897f1131029454 Mon Sep 17 00:00:00 2001 From: Josh Romero Date: Tue, 15 Aug 2023 20:48:44 +0000 Subject: [PATCH 3/3] Update ouiHeaderDarkBackgroundColor in next theme Signed-off-by: Josh Romero --- src/themes/oui-next/global_styling/variables/_header.scss | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/themes/oui-next/global_styling/variables/_header.scss b/src/themes/oui-next/global_styling/variables/_header.scss index b5fce32e85..e5f7abb3dd 100644 --- a/src/themes/oui-next/global_styling/variables/_header.scss +++ b/src/themes/oui-next/global_styling/variables/_header.scss @@ -11,7 +11,8 @@ // Themeable colors $ouiHeaderBackgroundColor: $ouiPageBackgroundColor !default; -$ouiHeaderDarkBackgroundColor: lightOrDarkTheme(shade($ouiColorDarkestShade, 28%), shade($ouiColorLightestShade, 50%)) !default; +// Always use the dark theme value of $ouiPageBackgroundColor for the dark header background +$ouiHeaderDarkBackgroundColor: #172430 !default; $ouiHeaderBorderColor: $ouiBorderColor !default; $ouiHeaderBreadcrumbColor: $ouiColorDarkestShade !default;