Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate the "Master" nomenclature #139

Closed
Tracked by #2589 ...
tlfeng opened this issue Mar 4, 2022 · 5 comments
Closed
Tracked by #2589 ...

Deprecate the "Master" nomenclature #139

tlfeng opened this issue Mar 4, 2022 · 5 comments
Assignees
Labels
enhancement New feature or request good first issue Good for newcomers v2.4.0 'Issues and PRs related to version v2.4.0'

Comments

@tlfeng
Copy link

tlfeng commented Mar 4, 2022

Is your feature request related to a problem? Please describe.
OpenSearch repository is going to replace the terminology "master"with "cluster manager".
issue: opensearch-project/OpenSearch#472, with the plan for its terminology replacement.

Although the existing usages with "master" will be supported in OpenSearch version 2.x to keep the backwards compatibility, please prepare for the nomenclature change in advance, and replace all the usages with "master" terminology in the code base.
All the OpenSearch REST APIs and settings that contain "master" terminology will be deprecated in 2.0, and alternative usages will be added.

Describe the solution you'd like
Replace the terminology "master" with "cluster manager".

When being compatible with OpenSearch 2.0:

  • Replace "master" in code comment and internal variable / method / class name.
  • Replace "master" in REST API request parameter and response
  • Replace OpenSearch REST API that contains "master" with the provided inclusive REST API
    such as replacing GET _cat/master with "GET _cat/cluster_manager"

Specifically,
The "master" terminology in the REST API will be exposed to the user, so should be prioritized.
Impacted REST API: GET <endpoint>:9600/_plugins/_performanceanalyzer/metrics
Document: https://opensearch.org/docs/1.3/monitoring-plugins/pa/api/
Detail: Names of 3 Performance Analyzer metrics can be contained in an optional parameter of the API request, and a field of the API response: Master_PendingQueueSize , Master_Task_Queue_Time , Master_Task_Run_Time .

Describe alternatives you've considered
None.

Additional context

@tlfeng tlfeng added the enhancement New feature or request label Mar 4, 2022
@dblock dblock added the v2.0.0 label Apr 18, 2022
@dblock dblock changed the title Change the "Master" nomenclature Deprecate the "Master" nomenclature Apr 18, 2022
@dblock
Copy link
Member

dblock commented Apr 18, 2022

For 2.0, at a minimum please ensure that the plugin is not calling any deprecated APIs in core or another plugin, and confirm below, then remove the 2.0.0 label. If you have time, do the complete deprecation as described in this issue.

@sruti1312
Copy link
Contributor

PA does not call any deprecated API's in core or another plugin.

@sruti1312 sruti1312 removed the v2.0.0 label Apr 18, 2022
@kkhatua kkhatua added the good first issue Good for newcomers label Jun 6, 2022
@sruti1312 sruti1312 removed the v2.1.0 label Jul 7, 2022
@kkhatua
Copy link
Member

kkhatua commented Jul 11, 2022

To be picked by @@kaushalmahi12

@anasalkouz
Copy link
Member

@sruti1312 @kaushalmahi12
Is there any remaining effort in this task? if not, please close the issue

@anasalkouz anasalkouz added v2.4.0 'Issues and PRs related to version v2.4.0' and removed v3.0.0 labels Sep 15, 2022
@anasalkouz
Copy link
Member

@kaushalmahi12 Can you close this? if we have everything merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers v2.4.0 'Issues and PRs related to version v2.4.0'
Projects
None yet
Development

No branches or pull requests

6 participants