[Custom log types] Support custom log types in detection rule creation and detector creation #676
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com>
Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com>
Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com>
Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com>
Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com>
Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com>
Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com>
Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com>
Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com>
Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com>
Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com>
Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com>
amsiglan
requested review from
AWSHurneyt,
getsaurabh02,
lezzago,
praveensameneni,
sbcd90 and
eirsep
as code owners
Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com>
Codecov Report
@@ Coverage Diff @@
## main #676 +/- ##
==========================================
- Coverage 31.37% 31.35% -0.03%
==========================================
Files 151 150 -1
Lines 4771 4759 -12
Branches 781 783 +2
==========================================
- Hits 1497 1492 -5
+ Misses 3096 3089 -7
Partials 178 178 |
AWSHurneyt
reviewed
Jul 31, 2023
Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com>
AWSHurneyt
reviewed
Jul 31, 2023
AWSHurneyt
approved these changes
Jul 31, 2023
lezzago
approved these changes
Jul 31, 2023
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Aug 1, 2023
…n and detector creation (#676) * log types table; details page with basic editing Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com> * implemented create, delete of log type Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com> * detection rules; delete modals added Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com> * updated snapshots Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com> * addressed PR comments Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com> * updated cypress workflow Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com> * use log types from API Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com> * updated detector cypress test Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com> * using api provided log types in rule creation Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com> * addressed PR comments Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com> * updated cypress test Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com> * updated nav panel Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com> * fixed log type labels; cypress tests Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com> --------- Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com> (cherry picked from commit 5388596)
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Aug 1, 2023
…n and detector creation (#676) * log types table; details page with basic editing Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com> * implemented create, delete of log type Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com> * detection rules; delete modals added Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com> * updated snapshots Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com> * addressed PR comments Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com> * updated cypress workflow Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com> * use log types from API Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com> * updated detector cypress test Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com> * using api provided log types in rule creation Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com> * addressed PR comments Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com> * updated cypress test Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com> * updated nav panel Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com> * fixed log type labels; cypress tests Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com> --------- Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com> (cherry picked from commit 5388596)
amsiglan
added a commit
that referenced
this pull request
Aug 2, 2023
…n and detector creation (#676) (#681) * log types table; details page with basic editing Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com> * implemented create, delete of log type Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com> * detection rules; delete modals added Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com> * updated snapshots Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com> * addressed PR comments Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com> * updated cypress workflow Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com> * use log types from API Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com> * updated detector cypress test Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com> * using api provided log types in rule creation Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com> * addressed PR comments Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com> * updated cypress test Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com> * updated nav panel Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com> * fixed log type labels; cypress tests Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com> --------- Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com> (cherry picked from commit 5388596) Co-authored-by: Amardeepsingh Siglani <amardeep7194@gmail.com>
amsiglan
added a commit
that referenced
this pull request
Aug 2, 2023
…n and detector creation (#676) (#682) * log types table; details page with basic editing Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com> * implemented create, delete of log type Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com> * detection rules; delete modals added Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com> * updated snapshots Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com> * addressed PR comments Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com> * updated cypress workflow Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com> * use log types from API Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com> * updated detector cypress test Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com> * using api provided log types in rule creation Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com> * addressed PR comments Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com> * updated cypress test Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com> * updated nav panel Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com> * fixed log type labels; cypress tests Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com> --------- Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com> (cherry picked from commit 5388596) Co-authored-by: Amardeepsingh Siglani <amardeep7194@gmail.com>
AWSHurneyt
pushed a commit
to AWSHurneyt/security-analytics-dashboards-plugin
that referenced
this pull request
Oct 12, 2023
…n and detector creation (opensearch-project#676) (opensearch-project#682) * log types table; details page with basic editing Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com> * implemented create, delete of log type Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com> * detection rules; delete modals added Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com> * updated snapshots Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com> * addressed PR comments Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com> * updated cypress workflow Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com> * use log types from API Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com> * updated detector cypress test Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com> * using api provided log types in rule creation Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com> * addressed PR comments Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com> * updated cypress test Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com> * updated nav panel Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com> * fixed log type labels; cypress tests Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com> --------- Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com> (cherry picked from commit 5388596) Co-authored-by: Amardeepsingh Siglani <amardeep7194@gmail.com> Signed-off-by: AWSHurneyt <hurneyt@amazon.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In this PR we have updated Detection rule and Detector workflows to support custom log types.
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.