Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] Add precommit hook to the pipeline #3471

Closed
willyborankin opened this issue Oct 5, 2023 · 1 comment · Fixed by #3727
Closed

[BUG] Add precommit hook to the pipeline #3471

willyborankin opened this issue Oct 5, 2023 · 1 comment · Fixed by #3727
Labels
bug Something isn't working triaged Issues labeled as 'Triaged' have been reviewed and are deemed actionable.

Comments

@willyborankin
Copy link
Collaborator

What is the bug?

Since we do not have a precommit hook in the pipeline it is possible to push and merge files without license header.
To fix the problem we need to add it to the pipeline.

Do you have any additional context?
Add any other context about the problem.
@willyborankin willyborankin added bug Something isn't working untriaged Require the attention of the repository maintainers and may need to be prioritized labels Oct 5, 2023
@willyborankin willyborankin mentioned this issue Oct 5, 2023
Merged
3 tasks
@stephen-crawford
Copy link
Contributor

[Triage] Hello @willyborankin, thank you for filing this issue. This looks good to me! I agree a precommit hook would be helpful here.

@stephen-crawford stephen-crawford added triaged Issues labeled as 'Triaged' have been reviewed and are deemed actionable. and removed untriaged Require the attention of the repository maintainers and may need to be prioritized labels Oct 9, 2023
@cwperks cwperks mentioned this issue Nov 16, 2023
Merged
3 tasks
willyborankin pushed a commit that referenced this issue Nov 17, 2023
@cwperks
Run precommit checks before checkstyle task (#3727)
9be1b27 
### Description

This PR runs the License Header check with the checkstyle CI check to
ensure that PRs contain licenses on top of new files. This PR also adds
the license on 2 files where its missing today.

* Category (Enhancement, New feature, Bug fix, Test fix, Refactoring,
Maintenance, Documentation)

Maintenance

### Issues Resolved

- Resolves #3471
- Resolves #3691

### Check List
- [ ] New functionality includes testing
- [ ] New functionality has been documented
- [ ] Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made
under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and
signing off your commits, please check
[here](https://github.com/opensearch-project/OpenSearch/blob/main/CONTRIBUTING.md#developer-certificate-of-origin).

---------

Signed-off-by: Craig Perkins <cwperx@amazon.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working triaged Issues labeled as 'Triaged' have been reviewed and are deemed actionable.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Run precommit checks before checkstyle task cwperks/security
2 participants
@willyborankin @stephen-crawford