Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup md files #1298

Merged
merged 8 commits into from
Jun 24, 2021
Merged

Cleanup md files #1298

merged 8 commits into from
Jun 24, 2021

Conversation

cliu123
Copy link
Member

@cliu123 cliu123 commented Jun 23, 2021

opensearch-security pull request intake form

Please provide as much details as possible to get feedback/acceptance on your PR quickly

  1. Category: (Enhancement, New feature, Bug fix, Test fix, Refactoring, Maintenance, Documentation)
    Maintenance

  2. Github Issue # or road-map entry, if available:
    Level up README and related markdown content #1297

  3. Description of changes:

  4. Why these changes are required?

  5. What is the old behavior before changes and new behavior after changes? (Please add any example/logs/screen-shot if available)

  6. Testing done: (Please provide details of testing done: Unit testing, integration testing and manual testing)

  7. TO-DOs, if any: (Please describe pending items and provide Github issues# for each of them)

  8. Is it backport from main branch? (If yes, please add backport PR # and commits #)

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
have the right to submit it under the open source license
indicated in the file; or

(b) The contribution is based upon previous work that, to the best
of my knowledge, is covered under an appropriate open source
license and I have the right under that license to submit that
work with modifications, whether created in whole or in part
by me, under the same open source license (unless I am
permitted to submit under a different license), as indicated
in the file; or

(c) The contribution was provided directly to me by some other
person who certified (a), (b) or (c) and I have not modified
it.

(d) I understand and agree that this project and the contribution
are public and that a record of the contribution (including all
personal information I submit with it, including my sign-off) is
maintained indefinitely and may be redistributed consistent with
this project or the open source license(s) involved.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@cliu123 cliu123 added the maintenance Project maintenance label Jun 23, 2021
@cliu123 cliu123 requested review from a team, dblock and saratvemulapalli June 23, 2021 23:24
@codecov-commenter
Copy link

Codecov Report

Merging #1298 (098aa8b) into main (4abbafc) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##               main    #1298   +/-   ##
=========================================
  Coverage     64.73%   64.73%           
- Complexity     3194     3195    +1     
=========================================
  Files           247      247           
  Lines         17230    17230           
  Branches       3045     3045           
=========================================
  Hits          11153    11153           
  Misses         4528     4528           
  Partials       1549     1549           
Impacted Files Coverage Δ
...a/org/opensearch/security/tools/SecurityAdmin.java 47.39% <0.00%> (-0.14%) ⬇️
.../dlic/auth/ldap2/LDAPConnectionFactoryFactory.java 58.01% <0.00%> (+0.76%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4abbafc...098aa8b. Read the comment docs.

Copy link
Member

@dblock dblock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good, we'll need to update ADMINS with recommendations from @CEHENKLE.

MAINTAINERS.md Show resolved Hide resolved
@cliu123 cliu123 merged commit 4ba3cc0 into opensearch-project:main Jun 24, 2021
@cliu123 cliu123 linked an issue Jul 14, 2021 that may be closed by this pull request
9 tasks
lbreinig pushed a commit to lbreinig/security that referenced this pull request Dec 23, 2021
@cliu123 cliu123 deleted the cleanup_md_files branch April 20, 2022 05:07
wuychn pushed a commit to ochprince/security that referenced this pull request Mar 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance Project maintenance
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Level up README and related markdown content
4 participants