Moved SNAPSHOTS repo to project level

[davidlago]

Signed-off-by: Dave Lago davelago@amazon.com

opensearch-security pull request intake form

Please provide as much details as possible to get feedback/acceptance on your PR quickly

1. Category: (Enhancement, New feature, Bug fix, Test fix, Refactoring, Maintenance, Documentation)

Maintenance

2. Github Issue # or road-map entry, if available:

Related to PR #1464

3. Description of changes:

Moved SNAPSHOTS maven repo to project level. It was previously at profile level, so it wouldn't be used when not applying profile advanced.

4. Why these changes are required?

Maven commands not applying the advanced profile don't use SNAPSHOTS repo

5. What is the old behavior before changes and new behavior after changes? (Please add any example/logs/screen-shot if available)

Not use SNAPSHOTS repo when not in advanced profile

6. Testing done: (Please provide details of testing done: Unit testing, integration testing and manual testing)

mvn -B checkstyle:checkstyle now works after clearing local maven cache

7. TO-DOs, if any: (Please describe pending items and provide Github issues# for each of them)

N/A

8. Is it backport from main branch? (If yes, please add backport PR # and commits #)

No

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
have the right to submit it under the open source license
indicated in the file; or

(b) The contribution is based upon previous work that, to the best
of my knowledge, is covered under an appropriate open source
license and I have the right under that license to submit that
work with modifications, whether created in whole or in part
by me, under the same open source license (unless I am
permitted to submit under a different license), as indicated
in the file; or

(c) The contribution was provided directly to me by some other
person who certified (a), (b) or (c) and I have not modified
it.

(d) I understand and agree that this project and the contribution
are public and that a record of the contribution (including all
personal information I submit with it, including my sign-off) is
maintained indefinitely and may be redistributed consistent with
this project or the open source license(s) involved.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

[codecov-commenter]

Codecov Report

Merging #1479 (dbd9ab5) into main (657160f) will decrease coverage by 0.01%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##               main    #1479      +/-   ##
============================================
- Coverage     64.89%   64.88%   -0.02%     
+ Complexity     3231     3229       -2     
============================================
  Files           247      247              
  Lines         17335    17335              
  Branches       3072     3072              
============================================
- Hits          11250    11247       -3     
- Misses         4530     4532       +2     
- Partials       1555     1556       +1     

Impacted Files	Coverage Δ
...ecurity/configuration/ConfigurationRepository.java	73.07% <0.00%> (-2.20%)	⬇️
.../dlic/auth/ldap2/LDAPConnectionFactoryFactory.java	56.48% <0.00%> (-1.53%)	⬇️
...security/configuration/DlsFlsFilterLeafReader.java	60.47% <0.00%> (+0.70%)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 657160f...dbd9ab5. Read the comment docs.