Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove HTTP_CHANNEL_KEY attributes since it is now available from the base class #2130

Merged
merged 1 commit into from
Oct 4, 2022

Conversation

reta
Copy link
Collaborator

@reta reta commented Sep 30, 2022

Signed-off-by: Andriy Redko andriy.redko@aiven.io

Description

Remove HTTP_CHANNEL_KEY attributes since it is now available from the base class (see please opensearch-project/OpenSearch#4638)

Issues Resolved

N/A

Testing

N/A

Check List

  • New functionality includes testing
  • New functionality has been documented
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@reta reta requested a review from a team September 30, 2022 12:04
@reta
Copy link
Collaborator Author

reta commented Sep 30, 2022

@peternied super minor one, probably need to wait for fresh 3.0.0 snapshots

peternied
peternied previously approved these changes Sep 30, 2022
@reta reta dismissed stale reviews from DarshitChanpura and peternied via a74458f October 3, 2022 13:15
@reta reta force-pushed the remove.http.key branch from 9d5eca0 to a74458f Compare October 3, 2022 13:15
… base class

Signed-off-by: Andriy Redko <andriy.redko@aiven.io>
@reta reta force-pushed the remove.http.key branch from a74458f to b3a3c25 Compare October 3, 2022 13:19
@reta reta requested review from peternied and DarshitChanpura and removed request for peternied and DarshitChanpura October 3, 2022 14:06
@peternied peternied merged commit b3452c1 into opensearch-project:main Oct 4, 2022
stephen-crawford pushed a commit to stephen-crawford/security that referenced this pull request Nov 10, 2022
… base class (opensearch-project#2130)

Signed-off-by: Andriy Redko <andriy.redko@aiven.io>
Signed-off-by: Stephen Crawford <steecraw@amazon.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants