Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add release workflows #74

Merged
merged 4 commits into from
Dec 15, 2022
Merged

Conversation

gaiksaya
Copy link
Member

@gaiksaya gaiksaya commented Dec 15, 2022

Description

This PR adds below things:

  • A GitHub action workflow that will be triggered when a tag is pushed to this repository. The workflow builds the release artifacts and creates a draft release with the built artifacts attached as artifacts.tar.gz in the draft release release.
  • A jenkins workflow that is triggered based on above draft release. The workflow looks for artifacts.tar.gz, downloads it and then signs it and publishes it to Maven.

Currently, I have kept the autoPublish tab as false since this is the first release, we would like to see the staged artifacts before we hit release. Also taking artifacts down from maven is a pain.

To-Do once the release is successful:

  • Change the autoPublish flag to true
  • Change the autoRelease tag to true

Issues Resolved

opensearch-project/opensearch-build#2846

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Sayali Gaikawad <gaiksaya@amazon.com>
Signed-off-by: Sayali Gaikawad <gaiksaya@amazon.com>
Signed-off-by: Sayali Gaikawad <gaiksaya@amazon.com>
Signed-off-by: Sayali Gaikawad <gaiksaya@amazon.com>
@rishabh6788
Copy link

is the jenkins job specific to spring-data-opensearch repo?
If yes, can we rename the jenkinsfile to something specific? @gaiksaya

@gaiksaya
Copy link
Member Author

gaiksaya commented Dec 15, 2022

I am going to add credentials to jenkins and set webhook for this repository. Please wait and allow me to merge.
Please review till then

@gaiksaya
Copy link
Member Author

is the jenkins job specific to spring-data-opensearch repo? If yes, can we rename the jenkinsfile to something specific? @gaiksaya

This is specific to this repo. I believe we dont need to name it spring data again in spring data repo.
Once we have publish snapshot ready we can add another workflow as publishSnapshot.jenkinsFile

@reta reta merged commit 3fb7dac into opensearch-project:main Dec 15, 2022
@gaiksaya gaiksaya deleted the add-release-workflows branch December 15, 2022 01:53
@reta
Copy link
Collaborator

reta commented Dec 30, 2022

@prudhvigodithi
Copy link
Member

Hey @reta I have noticed there was no successful run from past, will take a look to see whats going on.
Thank you
@gaiksaya

@gaiksaya
Copy link
Member Author

gaiksaya commented Jan 3, 2023

Hi @reta ,

I figured out the issue. Since the artifacts are quite large, it is trying to unzip before it was
can be downloaded completely. The incomplete download caused the error. https://github.com/opensearch-project/opensearch-build-libraries/tree/1.5.1/vars/standardReleasePipelineWithGenericTrigger.groovy#L82

I'll create a fix and update the jenkins file in this repo. Is it okay if I re-push the tag and re-create the pre-release?

@reta
Copy link
Collaborator

reta commented Jan 3, 2023

I'll create a fix and update the jenkins file in this repo. Is it okay if I re-push the tag and re-create the pre-release?

Thanks a lot @gaiksaya , yes, please feel free to re-push the tag and re-create the pre-release

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants