-
Notifications
You must be signed in to change notification settings - Fork 141
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rework on OpenSearchDataType
: parse, store and use mapping information
#1314
Merged
Yury-Fridlyand
merged 7 commits into
opensearch-project:main
from
Bit-Quill:integ-spike-rework-mapping-use
Mar 21, 2023
Merged
Changes from 3 commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
c9d106a
Rework on `OpenSearchDataType`: parse, store and use mapping informat…
Yury-Fridlyand be66e97
Rename `getInstance()` of derived `OpenSearchDataType`s to `of()` to …
Yury-Fridlyand c69b0eb
Merge remote-tracking branch 'upstream/main' into integ-spike-rework-…
Yury-Fridlyand a6cf875
Update docs - reflect real data types reported in SQL and PPL for tex…
Yury-Fridlyand d47c624
Add cache for field data types.
Yury-Fridlyand b968514
Minor performance improvement.
Yury-Fridlyand be7e9c7
Statically init instances of `OpenSearchDataType`.
Yury-Fridlyand File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
35 changes: 35 additions & 0 deletions
35
opensearch/src/main/java/org/opensearch/sql/opensearch/data/type/OpenSearchBinaryType.java
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,35 @@ | ||
/* | ||
* Copyright OpenSearch Contributors | ||
* SPDX-License-Identifier: Apache-2.0 | ||
*/ | ||
|
||
|
||
package org.opensearch.sql.opensearch.data.type; | ||
|
||
import static org.opensearch.sql.data.type.ExprCoreType.UNKNOWN; | ||
|
||
import lombok.EqualsAndHashCode; | ||
|
||
/** | ||
* The type of a binary value. See | ||
* <a href="https://opensearch.org/docs/latest/opensearch/supported-field-types/binary/">doc</a> | ||
*/ | ||
@EqualsAndHashCode(callSuper = false) | ||
public class OpenSearchBinaryType extends OpenSearchDataType { | ||
|
||
private static final OpenSearchBinaryType instance = new OpenSearchBinaryType(); | ||
|
||
private OpenSearchBinaryType() { | ||
super(MappingType.Binary); | ||
exprCoreType = UNKNOWN; | ||
} | ||
|
||
public static OpenSearchBinaryType of() { | ||
return OpenSearchBinaryType.instance; | ||
} | ||
|
||
@Override | ||
protected OpenSearchDataType cloneEmpty() { | ||
return instance; | ||
} | ||
} |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
return instrance?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A singleton