Documentation Proposal for Nested Function in WHERE Clause
#1640
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
forestmvey
requested review from
pjfitzgibbons,
ps48,
kavithacm,
derek-ho,
joshuali925,
dai-chen,
YANG-DB,
rupal-bq,
mengweieric,
vmmusings,
Swiddis,
penghuo,
seankao-az,
MaxKsyunz,
Yury-Fridlyand,
anirudha and
acarbonetto
as code owners
Codecov Report
@@ Coverage Diff @@
## main #1640 +/- ##
=========================================
Coverage 97.16% 97.16%
Complexity 4120 4120
=========================================
Files 371 371
Lines 10373 10373
Branches 704 704
=========================================
Hits 10079 10079
Misses 287 287
Partials 7 7
Flags with carried forward coverage won't be shown. Click here to find out more. |
dai-chen
previously approved these changes
May 23, 2023
forestmvey
force-pushed
the
integ-nested-where-clause-doc
branch
from
afd664e to
d26adf2
Compare
GumpacG
previously approved these changes
May 24, 2023
acarbonetto
approved these changes
May 24, 2023
acarbonetto
previously approved these changes
May 24, 2023
6 tasks
GumpacG
previously approved these changes
May 25, 2023
6 tasks
Yury-Fridlyand
previously approved these changes
May 26, 2023
Signed-off-by: forestmvey <forestv@bitquilltech.com>
Signed-off-by: forestmvey <forestv@bitquilltech.com>
forestmvey
force-pushed
the
integ-nested-where-clause-doc
branch
from
9a43b63 to
4fa0440
Compare
acarbonetto
previously approved these changes
May 30, 2023
…ization strategy. Signed-off-by: forestmvey <forestv@bitquilltech.com>
forestmvey
dismissed stale reviews from acarbonetto, Yury-Fridlyand, and GumpacG
via
967da5b
GumpacG
approved these changes
May 30, 2023
Yury-Fridlyand
approved these changes
May 30, 2023
acarbonetto
approved these changes
May 30, 2023
MitchellGale
approved these changes
May 30, 2023
matthewryanwells
approved these changes
May 30, 2023
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
May 30, 2023
* Adding documentation for nested function use in WHERE clause. Signed-off-by: forestmvey <forestv@bitquilltech.com> * Revising sections based on PR feedback. Signed-off-by: forestmvey <forestv@bitquilltech.com> * Adding link for flattening details and filling in section with normalization strategy. Signed-off-by: forestmvey <forestv@bitquilltech.com> --------- Signed-off-by: forestmvey <forestv@bitquilltech.com> (cherry picked from commit 93c7a5f)
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
May 30, 2023
* Adding documentation for nested function use in WHERE clause. Signed-off-by: forestmvey <forestv@bitquilltech.com> * Revising sections based on PR feedback. Signed-off-by: forestmvey <forestv@bitquilltech.com> * Adding link for flattening details and filling in section with normalization strategy. Signed-off-by: forestmvey <forestv@bitquilltech.com> --------- Signed-off-by: forestmvey <forestv@bitquilltech.com> (cherry picked from commit 93c7a5f)
forestmvey
added a commit
that referenced
this pull request
May 30, 2023
Signed-off-by: forestmvey <forestv@bitquilltech.com>
forestmvey
added a commit
that referenced
this pull request
May 30, 2023
Signed-off-by: forestmvey <forestv@bitquilltech.com>
acarbonetto
pushed a commit
that referenced
this pull request
May 30, 2023
Yury-Fridlyand
pushed a commit
that referenced
this pull request
May 30, 2023
MitchellGale
pushed a commit
to Bit-Quill/opensearch-project-sql
that referenced
this pull request
Jun 12, 2023
…rch-project#1640) * Adding documentation for nested function use in WHERE clause. Signed-off-by: forestmvey <forestv@bitquilltech.com> * Revising sections based on PR feedback. Signed-off-by: forestmvey <forestv@bitquilltech.com> * Adding link for flattening details and filling in section with normalization strategy. Signed-off-by: forestmvey <forestv@bitquilltech.com> --------- Signed-off-by: forestmvey <forestv@bitquilltech.com>
MitchellGale
pushed a commit
to Bit-Quill/opensearch-project-sql
that referenced
this pull request
Jun 12, 2023
…rch-project#1640) * Adding documentation for nested function use in WHERE clause. Signed-off-by: forestmvey <forestv@bitquilltech.com> * Revising sections based on PR feedback. Signed-off-by: forestmvey <forestv@bitquilltech.com> * Adding link for flattening details and filling in section with normalization strategy. Signed-off-by: forestmvey <forestv@bitquilltech.com> --------- Signed-off-by: forestmvey <forestv@bitquilltech.com> Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add documentation for
nestedfunction use inWHEREclause of an SQL statement. Document covers two syntax options brought forward from legacy engine. Work on implementation is WIP but should align with this added documentation.Syntax Options:
nested(path, condition)nested(field, field | path) OPERATOR LITERALCheck List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.