Fix typescript 4 errors part 3 #1876
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
For the record, this thread seems to be relevant |
|
How can we enforce |
With a quick search, I found this Maybe it makes more sense to include it in the mono-repo instead of the master branch? |
jkilzi
approved these changes
Jan 19, 2023
ammont82
approved these changes
Jan 19, 2023
jkilzi
added a commit
to jkilzi/assisted-installer-ui
that referenced
this pull request
Jan 19, 2023
* Fixing typescript errors in v4 * Async dispatch
jkilzi
added a commit
to jkilzi/assisted-installer-ui
that referenced
this pull request
Jan 19, 2023
* Fixing typescript errors in v4 * Async dispatch
celdrake
pushed a commit
to celdrake/assisted-ui-lib
that referenced
this pull request
Jan 27, 2023
* Fixing typescript errors in v4 * Async dispatch
jkilzi
added a commit
to jkilzi/assisted-installer-ui
that referenced
this pull request
Jan 29, 2023
* Fixing typescript errors in v4 * Async dispatch
celdrake
pushed a commit
to celdrake/assisted-ui-lib
that referenced
this pull request
Jan 30, 2023
* Fixing typescript errors in v4 * Async dispatch
jkilzi
added a commit
to jkilzi/assisted-installer-ui
that referenced
this pull request
Jan 30, 2023
* Fixing typescript errors in v4 * Async dispatch
jkilzi
added a commit
to jkilzi/assisted-installer-ui
that referenced
this pull request
Jan 30, 2023
* Fixing typescript errors in v4 * Async dispatch
jkilzi
added a commit
to jkilzi/assisted-installer-ui
that referenced
this pull request
Jan 30, 2023
* Fixing typescript errors in v4 * Async dispatch
jkilzi
added a commit
to jkilzi/assisted-installer-ui
that referenced
this pull request
Jan 30, 2023
* Fixing typescript errors in v4 * Async dispatch
jkilzi
added a commit
to jkilzi/assisted-installer-ui
that referenced
this pull request
Feb 2, 2023
* Fixing typescript errors in v4 * Async dispatch
jkilzi
added a commit
to jkilzi/assisted-installer-ui
that referenced
this pull request
Feb 2, 2023
* Fixing typescript errors in v4 * Async dispatch
jkilzi
added a commit
to jkilzi/assisted-installer-ui
that referenced
this pull request
Feb 19, 2023
* Fixing typescript errors in v4 * Async dispatch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a typed equivalent to
Object.keyswhich returns a type based on the object.This makes the casting when accessing the values unnecessary.