Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lca: Limiting the client for pull and newbuilder for lca #315

Merged
merged 1 commit into from
Apr 4, 2024

Conversation

achuzhoy
Copy link
Collaborator

@achuzhoy achuzhoy commented Apr 3, 2024

This is based on assignment
#299

@achuzhoy
Copy link
Collaborator Author

achuzhoy commented Apr 3, 2024

cc @trewest @kononovn

@achuzhoy
Copy link
Collaborator Author

achuzhoy commented Apr 3, 2024

successfully tested

@sebrandon1
Copy link
Collaborator

It's interesting that the Client variable is actually an interface.

@trewest
Copy link
Collaborator

trewest commented Apr 4, 2024

It's interesting that the Client variable is actually an interface.

@sebrandon1 I think this is the underlying struct that implements Client. It's set here

pkg/lca/seedgenerator.go Outdated Show resolved Hide resolved
Copy link
Collaborator

@trewest trewest left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one minor comment

This is based on assignment
openshift-kni#299

Signed-off-by: Alexander Chuzhoy <achuzhoy@redhat.com>
Copy link
Collaborator

@trewest trewest left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@trewest trewest merged commit ed7ca3e into openshift-kni:main Apr 4, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants