From 743111a3f4f4ec60e590b82f3022e63888b31836 Mon Sep 17 00:00:00 2001 From: Guilherme Branco Date: Wed, 26 Jul 2023 14:53:49 -0300 Subject: [PATCH] OCM-2941 | fix: Adjusting help usage and ingress builder call --- cmd/ocm/create/cluster/cmd.go | 3 ++- cmd/ocm/edit/ingress/cmd.go | 5 +++-- 2 files changed, 5 insertions(+), 3 deletions(-) diff --git a/cmd/ocm/create/cluster/cmd.go b/cmd/ocm/create/cluster/cmd.go index f742cffc..21faffe8 100644 --- a/cmd/ocm/create/cluster/cmd.go +++ b/cmd/ocm/create/cluster/cmd.go @@ -275,7 +275,8 @@ func init() { defaultIngressRouteSelectorFlag, "", "Route Selector for ingress. Format should be a comma-separated list of 'key=value'. "+ - "If no label is specified, all routes will be exposed on both routers.", + "If no label is specified, all routes will be exposed on both routers."+ + " For legacy ingress support these are inclusion labels, otherwise they are treated as exclusion label.", ) fs.StringVar( diff --git a/cmd/ocm/edit/ingress/cmd.go b/cmd/ocm/edit/ingress/cmd.go index b25b3ede..45f41965 100644 --- a/cmd/ocm/edit/ingress/cmd.go +++ b/cmd/ocm/edit/ingress/cmd.go @@ -101,7 +101,8 @@ func init() { routeSelectorFlag, "", "Route Selector for ingress. Format should be a comma-separated list of 'key=value'. "+ - "If no label is specified, all routes will be exposed on both routers.", + "If no label is specified, all routes will be exposed on both routers."+ + " For legacy ingress support these are inclusion labels, otherwise they are treated as exclusion label.", ) flags.StringVar( @@ -295,7 +296,7 @@ func run(cmd *cobra.Command, argv []string) error { if cluster.Hypershift().Enabled() { return fmt.Errorf("Can't edit `%s` for Hosted Control Plane clusters", clusterRoutesTlsSecretRefFlag) } - ingressBuilder = ingressBuilder.ClusterRoutesHostname(args.clusterRoutesTlsSecretRef) + ingressBuilder = ingressBuilder.ClusterRoutesTlsSecretRef(args.clusterRoutesTlsSecretRef) } ingress, err = ingressBuilder.Build()