cleanup

- code cleanup

pkg/provider/azuredevops/detect.go

@@ -38,7 +38,6 @@ func (v *Provider) Detect(req *http.Request, payload string, logger *zap.Sugared
 	normalizedEventType := strings.ReplaceAll(*event.EventType, "-", ".")
 	if strings.Contains(normalizedEventType, eventType) {
 		logger = logger.With("provider", "azuredevops", "event-type", eventType)
-		// Simplified switch, expand as needed based on the Azure DevOps events you handle
 		switch eventType {
 		case "git.push", "git.pullrequest.created", "git.pullrequest.updated", "git.pullrequest.comment":
 			return setLoggerAndProceed(true, "", nil)

pkg/provider/azuredevops/detect_test.go

@@ -15,7 +15,6 @@ func TestProvider_Detect(t *testing.T) {
 	gitPush := "git.push"
 	gitPRCreated := "git.pullrequest.created"
 	gitPRUpdated := "git.pullrequest.updated"
-	// Define more event types as needed
 
 	tests := []struct {
 		name          string
@@ -80,7 +79,7 @@ func TestProvider_Detect(t *testing.T) {
 			header.Set("X-Azure-DevOps-EventType", tt.eventType)
 			req := &http.Request{Header: header}
 
-			v := Provider{} // Assuming Provider is your Azure DevOps provider struct
+			v := Provider{}
 			isADO, processReq, _, reason, err := v.Detect(req, string(payload), logger)
 
 			if tt.wantErr {

pkg/provider/azuredevops/parse_payload.go

@@ -30,7 +30,6 @@ func (v *Provider) ParsePayload(_ context.Context, _ *params.Run, req *http.Requ
 	processedEvent := info.NewEvent()
 
 	processedEvent.EventType = req.Header.Get("X-Azure-DevOps-EventType")
-	// processedEvent.EventType = *genericEvent.EventType
 
 	resourceBytes, err := json.Marshal(genericEvent.Resource)
 	if err != nil {
@@ -63,7 +62,6 @@ func (v *Provider) ParsePayload(_ context.Context, _ *params.Run, req *http.Requ
 		processedEvent.URL = pushEvent.Repository.RemoteURL
 		processedEvent.DefaultBranch = pushEvent.Repository.DefaultBranch
 		processedEvent.TriggerTarget = triggertype.Push
-		// Assuming the repository URL can serve as both BaseURL and HeadURL for viewing purposes
 		processedEvent.BaseURL = pushEvent.Repository.URL
 		processedEvent.HeadURL = pushEvent.Repository.URL
 		if len(pushEvent.RefUpdates) > 0 {
@@ -84,19 +82,12 @@ func (v *Provider) ParsePayload(_ context.Context, _ *params.Run, req *http.Requ
 		processedEvent.SHAURL = prEvent.LastMergeSourceCommit.URL
 		processedEvent.SHATitle = prEvent.LastMergeSourceCommit.Comment
 
-		// Extract branch names from the ref names
-		// Azure DevOps ref names are full references (refs/heads/branchName), so we'll extract the branch name
 		processedEvent.BaseBranch = ExtractBranchName(prEvent.TargetRefName)
 		processedEvent.HeadBranch = ExtractBranchName(prEvent.SourceRefName)
 		processedEvent.DefaultBranch = prEvent.Repository.DefaultBranch
 
-		// Constructing URLs
-		remoteURL := *prEvent.Repository.WebURL
-		// processedEvent.BaseURL = fmt.Sprintf("%s?version=GB%s", remoteURL, processedEvent.BaseBranch)
-		// processedEvent.HeadURL = fmt.Sprintf("%s?version=GB%s", remoteURL, processedEvent.HeadBranch)
-
 		processedEvent.TriggerTarget = triggertype.PullRequest
-
+		remoteURL := *prEvent.Repository.WebURL
 		baseURL, err := ExtractBaseURL(remoteURL)
 		if err != nil {
 			return nil, fmt.Errorf("not able to extract organization url")

pkg/provider/azuredevops/parse_payload_test.go

@@ -11,7 +11,6 @@ import (
 )
 
 func TestParsePayload(t *testing.T) {
-	// Mock request setup
 	mockRequest := &http.Request{}
 
 	// Mock context
@@ -115,7 +114,7 @@ func TestParsePayload(t *testing.T) {
 
 	for _, tt := range tests {
 		t.Run(tt.name, func(t *testing.T) {
-			v := Provider{} // Assuming this is your Azure DevOps provider
+			v := Provider{}
 			run := &params.Run{}
 
 			gotEvent, err := v.ParsePayload(ctx, run, mockRequest, tt.payload)
@@ -126,7 +125,6 @@ func TestParsePayload(t *testing.T) {
 
 			assert.Equal(t, tt.wantEvent.EventType, gotEvent.EventType)
 			assert.Equal(t, tt.wantEvent.SHA, gotEvent.SHA)
-			// Add more assertions as needed
 		})
 	}
 }

pkg/provider/azuredevops/test/setup.go

@@ -77,7 +77,7 @@ func (m *MockCoreClient) GetTeamMembersWithExtendedProperties(ctx context.Contex
 
 	var teamMembers []webapi.TeamMember
 	for _, memberID := range members {
-		identityID := memberID // Simplifying identity ID use case
+		identityID := memberID
 		teamMembers = append(teamMembers, webapi.TeamMember{
 			Identity: &webapi.IdentityRef{Id: &identityID},
 		})