Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ultraSSDEnabled to Azure Machine Provider Spec #1130

Closed
wants to merge 1 commit into from

Conversation

jstuever
Copy link
Contributor

@jstuever jstuever commented Mar 3, 2022

This change adds the ability to specify if ultra SSD is enabled as part
of the additional capabilities of an Azure machine. This is needed in
order to enable UltraSSD disks on compute and control plane
instances.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Mar 3, 2022

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: jstuever
To complete the pull request process, please assign jwforres after the PR has been reviewed.
You can assign the PR to them by writing /assign @jwforres in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jstuever jstuever changed the title Add ultraSSDEnabled to Azure Machine Provider Spec WIP: Add ultraSSDEnabled to Azure Machine Provider Spec Mar 3, 2022
@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 3, 2022
@jstuever jstuever force-pushed the cors1893 branch 2 times, most recently from f87074c to 8b34505 Compare March 3, 2022 03:34
This change adds the ability to specify if ultra SSD is enabled as part
of the additional capabilities of an Azure machine.
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Mar 3, 2022

@jstuever: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@jstuever jstuever changed the title WIP: Add ultraSSDEnabled to Azure Machine Provider Spec Add ultraSSDEnabled to Azure Machine Provider Spec Mar 3, 2022
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 3, 2022
@jstuever
Copy link
Contributor Author

jstuever commented Mar 3, 2022

This is needed for https://issues.redhat.com/browse/CORS-1893

@JoelSpeed
Copy link
Contributor

This will conflict with #1119 which is trying to solve the same issue, @damdo @jstuever can you please coordinate your efforts

@JoelSpeed
Copy link
Contributor

@jstuever Have you got an enhancement that relates to the work you are doing? There was one merged for Machine API already openshift/enhancements#1021

@jstuever
Copy link
Contributor Author

jstuever commented Mar 3, 2022

@jstuever Have you got an enhancement that relates to the work you are doing? There was one merged for Machine API already openshift/enhancements#1021

I'm not sure if there is an enhancement. I am working on epic https://issues.redhat.com/browse/CORS-1836, which was created for https://issues.redhat.com/browse/RFE-1698. I see https://issues.redhat.com/browse/OCPCLOUD-1423 is also linked to that RFE. I wasn't sure the timeline for https://issues.redhat.com/browse/OCPCLOUD-1423. I am blocked by the need for the Machine API work, so I submitted this PR knowing it would be needed by both efforts. If there is already another PR in flight, I'd be happy to go with that.

@jstuever jstuever closed this Mar 7, 2022
@jstuever jstuever deleted the cors1893 branch May 3, 2022 20:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants