-
Notifications
You must be signed in to change notification settings - Fork 518
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ultraSSDEnabled to Azure Machine Provider Spec #1130
Conversation
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: jstuever The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
f87074c
to
8b34505
Compare
This change adds the ability to specify if ultra SSD is enabled as part of the additional capabilities of an Azure machine.
@jstuever: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
This is needed for https://issues.redhat.com/browse/CORS-1893 |
@jstuever Have you got an enhancement that relates to the work you are doing? There was one merged for Machine API already openshift/enhancements#1021 |
I'm not sure if there is an enhancement. I am working on epic https://issues.redhat.com/browse/CORS-1836, which was created for https://issues.redhat.com/browse/RFE-1698. I see https://issues.redhat.com/browse/OCPCLOUD-1423 is also linked to that RFE. I wasn't sure the timeline for https://issues.redhat.com/browse/OCPCLOUD-1423. I am blocked by the need for the Machine API work, so I submitted this PR knowing it would be needed by both efforts. If there is already another PR in flight, I'd be happy to go with that. |
This change adds the ability to specify if ultra SSD is enabled as part
of the additional capabilities of an Azure machine. This is needed in
order to enable UltraSSD disks on compute and control plane
instances.