Split CRD schema check into separate Makefile target #1568
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the schema check fails, it may need to be overridden. By splitting into it's own target, make will continue to execute other dependencies, but report only the failure of verify-crd-schema.
Presently if it fails, it reports that verify-scripts failed, which is not ideal, since we require this to pass.
I would like to have a separate status check on GitHub for the two sets, those that must pass and those that may not, so will sort that once this is merged. But the intention is that
make verifystill works locally for devs