Skip to content

Conversation

@JoelSpeed
Copy link
Contributor

When the schema check fails, it may need to be overridden. By splitting into it's own target, make will continue to execute other dependencies, but report only the failure of verify-crd-schema.

Presently if it fails, it reports that verify-scripts failed, which is not ideal, since we require this to pass.

I would like to have a separate status check on GitHub for the two sets, those that must pass and those that may not, so will sort that once this is merged. But the intention is that make verify still works locally for devs

When the schema check fails, it may need to be overridden.
By splitting into it's own target, make will continue to execute other dependencies, but report only the failure of verify-crd-schema.

Presently if it fails, it reports that verify-scripts failed, which is not ideal, since we require this to pass.
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 25, 2023

Hello @JoelSpeed! Some important instructions when contributing to openshift/api:
API design plays an important part in the user experience of OpenShift and as such API PRs are subject to a high level of scrutiny to ensure they follow our best practices. If you haven't already done so, please review the OpenShift API Conventions and ensure that your proposed changes are compliant. Following these conventions will help expedite the api review process for your PR.

@openshift-ci openshift-ci bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Aug 25, 2023
@openshift-ci openshift-ci bot requested review from bparees and soltysh August 25, 2023 09:57
@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 25, 2023
@deads2k
Copy link
Contributor

deads2k commented Aug 25, 2023

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Aug 25, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 25, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: deads2k, JoelSpeed

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 25, 2023

@JoelSpeed: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-robot openshift-merge-robot merged commit 938af62 into openshift:master Aug 25, 2023
@JoelSpeed JoelSpeed deleted the crd-schema-separate branch August 25, 2023 16:01
jstuever added a commit to jstuever/api that referenced this pull request Sep 13, 2023
…eparate"

This reverts commit 938af62, reversing
changes made to f9d67cd.
jstuever added a commit to jstuever/api that referenced this pull request Sep 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants