Skip to content

CONSOLE-4055: Cluster setting for hiding "Getting started resources" banner from Overview #1992

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 3 commits into from
Closed

CONSOLE-4055: Cluster setting for hiding "Getting started resources" banner from Overview #1992

wants to merge 3 commits into from

Conversation

@nitin-dhevar
Copy link
Contributor

@nitin-dhevar nitin-dhevar commented Aug 6, 2024

No description provided.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Aug 6, 2024
@openshift-ci-robot
Copy link

openshift-ci-robot commented Aug 6, 2024 •
edited by openshift-ci bot
Loading

@nitin-dhevar: This pull request references CONSOLE-4055 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.17.0" version, but no target version was set.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 6, 2024

Hello @nitin-dhevar! Some important instructions when contributing to openshift/api:
API design plays an important part in the user experience of OpenShift and as such API PRs are subject to a high level of scrutiny to ensure they follow our best practices. If you haven't already done so, please review the OpenShift API Conventions and ensure that your proposed changes are compliant. Following these conventions will help expedite the api review process for your PR.

@openshift-ci openshift-ci bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Aug 6, 2024
@openshift-ci openshift-ci bot requested review from bparees and deads2k August 6, 2024 16:20
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 6, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: nitin-dhevar
Once this PR has been reviewed and has the lgtm label, please assign joelspeed for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@nitin-dhevar
Copy link
Contributor Author

nitin-dhevar commented Aug 6, 2024

/assign @jhadvig

jhadvig
jhadvig suggested changes Aug 7, 2024
View reviewed changes
Copy link
Member

@jhadvig jhadvig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

THanks @nitin-dhevar for the PR. Adding couple of comments.
Could you also add the new capability name to the Capability field description in the ConsoleCustomization structure, line 151.
Thank you 🙌

operator/v1/types_console.go Outdated
// lightspeedButton is the name for the Lightspeed button HTML element.
LightspeedButton ConsoleCapabilityName = "LightspeedButton"

// gettingStartedState defines the state of getting started resources in the console UI.
Copy link
Member

@jhadvig jhadvig Aug 7, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
// gettingStartedState defines the state of getting started resources in the console UI.
// gettingStartedState is the name of the 'Getting started resources' banner in the console UI Overview page.

operator/v1/types_console.go Outdated
LightspeedButton ConsoleCapabilityName = "LightspeedButton"

// gettingStartedState defines the state of getting started resources in the console UI.
GettingStartedBannerState ConsoleCapabilityName = "GettingStartedBannerState"
Copy link
Member

@jhadvig jhadvig Aug 7, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
GettingStartedBannerState ConsoleCapabilityName = "GettingStartedBannerState"
GettingStartedBanner ConsoleCapabilityName = "GettingStartedBanner"

operator/v1/types_console.go Outdated
// name is the unique name of a capability.
// Available capabilities are LightspeedButton.
// +kubebuilder:validation:Enum:="LightspeedButton";
// Available capabilities are LightspeedButton and GettingStartedBannerState.
Copy link
Member

@jhadvig jhadvig Aug 7, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
// Available capabilities are LightspeedButton and GettingStartedBannerState.
// Available capabilities are LightspeedButton and GettingStartedBanner.

operator/v1/types_console.go Outdated
// Available capabilities are LightspeedButton.
// +kubebuilder:validation:Enum:="LightspeedButton";
// Available capabilities are LightspeedButton and GettingStartedBannerState.
// +kubebuilder:validation:Enum:="LightspeedButton";"GettingStartedBannerState"
Copy link
Member

@jhadvig jhadvig Aug 7, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
// +kubebuilder:validation:Enum:="LightspeedButton";"GettingStartedBannerState"
// +kubebuilder:validation:Enum:="LightspeedButton";"GettingStartedBanner"

@openshift-ci openshift-ci bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Aug 7, 2024
@nitin-dhevar nitin-dhevar requested a review from jhadvig August 7, 2024 13:23
@nitin-dhevar
Copy link
Contributor Author

nitin-dhevar commented Aug 7, 2024

/label tide/merge-method-squash

@openshift-ci openshift-ci bot added the tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges. label Aug 7, 2024
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 7, 2024

@nitin-dhevar: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/verify 01cacf5 link true /test verify
ci/prow/images 01cacf5 link true /test images

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@jhadvig jhadvig mentioned this pull request Aug 29, 2024
Merged
@jhadvig
Copy link
Member

jhadvig commented Aug 29, 2024

Closing in favor of #2015

@jhadvig
Copy link
Member

jhadvig commented Aug 29, 2024

/close

@openshift-ci openshift-ci bot closed this Aug 29, 2024
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 29, 2024

@jhadvig: Closed this PR.

In response to this:

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bparees bparees Awaiting requested review from bparees

@deads2k deads2k Awaiting requested review from deads2k

@jhadvig jhadvig Awaiting requested review from jhadvig

Assignees

@jhadvig jhadvig

Labels

jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@nitin-dhevar @openshift-ci-robot @jhadvig