Bug 2086519: scc: set container nonroot=true if the pod/container RunAsUser is non-zero #85
Conversation
openshift-ci
bot
added
the
approved
| nonRoot := true | ||
| sc.SetRunAsNonRoot(&nonRoot) | ||
| // Alternatively, also set the RunAsNonRoot to true in case the UID value is non-nil and non-zero | ||
| // to more easily satisfy the requirements of upstream PodSecurity admission "restricted" profile |
There was a problem hiding this comment.
A future me wouldn't know how why this is the case and how this is related to kubelet's logic. Please add some more rationale and references why this is useful.
…-zero PodSecurity admission requires the non-zero flag to be set no matter the container/pod UID.
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: s-urbaniak, stlaz The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
stlaz
changed the title
openshift-ci
bot
added
bugzilla/severity-urgent
|
@stlaz: This pull request references Bugzilla bug 2086519, which is valid. The bug has been updated to refer to the pull request using the external bug tracker. 3 validation(s) were run on this bug
No GitHub users were found matching the public email listed for the QA contact in Bugzilla (ytripath@redhat.com), skipping review request. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@stlaz: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
@stlaz: Some pull requests linked via external trackers have merged:
The following pull requests linked via external trackers have not merged:
These pull request must merge or be unlinked from the Bugzilla bug in order for it to move to the next state. Once unlinked, request a bug refresh with Bugzilla bug 2086519 has not been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
PodSecurity admission requires the non-zero flag to be set no matter
the container/pod UID.
/assign @deads2k