Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

settings: use occurrences notation for file settings #245

Conversation

steveej
Copy link
Contributor

@steveej steveej commented Mar 9, 2020

This allows using the same notation for verbosity in the deployment
template, regardless of whether its passed as to the graph-builder as a
CLI flag or config file entry.

@openshift-ci-robot openshift-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Mar 9, 2020
Copy link
Member

@vrutkovs vrutkovs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Mar 9, 2020
@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 9, 2020
@steveej steveej changed the title gb/settings: use occurences notation for file settings gb/settings: use occurrences notation for file settings Mar 9, 2020
@steveej steveej force-pushed the pr/gb-configfile-verbosity-from-occurrences branch from 4514122 to 3a2792a Compare March 9, 2020 14:10
Copy link
Member

@LalatenduMohanty LalatenduMohanty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@steveej steveej force-pushed the pr/gb-configfile-verbosity-from-occurrences branch from 3a2792a to 0bbd8a3 Compare March 9, 2020 14:10
@openshift-ci-robot openshift-ci-robot removed the lgtm Indicates that a PR is ready to be merged. label Mar 9, 2020
Copy link
Member

@LalatenduMohanty LalatenduMohanty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Mar 9, 2020
@steveej
Copy link
Contributor Author

steveej commented Mar 9, 2020

/retest
/refresh

@steveej steveej force-pushed the pr/gb-configfile-verbosity-from-occurrences branch from 0bbd8a3 to 2b968c3 Compare March 9, 2020 16:11
@openshift-ci-robot openshift-ci-robot removed the lgtm Indicates that a PR is ready to be merged. label Mar 9, 2020
@steveej steveej changed the title gb/settings: use occurrences notation for file settings settings: use occurrences notation for file settings Mar 9, 2020
This allows using the same notation for verbosity in the deployment
template, regardless of whether its passed as to the graph-builder as a
CLI flag or config file entry.
@steveej steveej force-pushed the pr/gb-configfile-verbosity-from-occurrences branch from 2b968c3 to 2834fbf Compare March 9, 2020 16:16
Copy link
Member

@LalatenduMohanty LalatenduMohanty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Mar 9, 2020
@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: LalatenduMohanty, steveeJ, vrutkovs

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [LalatenduMohanty,steveeJ,vrutkovs]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit 04327cc into openshift:master Mar 9, 2020
@steveej steveej deleted the pr/gb-configfile-verbosity-from-occurrences branch March 9, 2020 19:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants