Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug 2086519: exempt build controller SA from PodSecurity admission #1358

Merged
merged 1 commit into from
Jun 3, 2022
Merged

Bug 2086519: exempt build controller SA from PodSecurity admission #1358

merged 1 commit into from
Jun 3, 2022

Conversation

stlaz
Copy link
Contributor

@stlaz stlaz commented May 26, 2022

/assign @deads2k

@stlaz
Copy link
Contributor Author

stlaz commented May 26, 2022

/cc @s-urbaniak

@deads2k
Copy link
Contributor

deads2k commented May 26, 2022

after comments, lgtm.

@s-urbaniak s-urbaniak mentioned this pull request May 31, 2022
Closed
@s-urbaniak
Copy link
Contributor

/lgtm

@deads2k
Copy link
Contributor

deads2k commented May 31, 2022

/approve

@openshift-ci
Copy link
Contributor

openshift-ci bot commented May 31, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: deads2k, s-urbaniak, stlaz

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 31, 2022
@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label May 31, 2022
@stlaz
Copy link
Contributor Author

stlaz commented Jun 1, 2022

/retest-required

1 similar comment
@stlaz
Copy link
Contributor Author

stlaz commented Jun 1, 2022

/retest-required

@stlaz stlaz changed the title exempt build controller SA from PodSecurity admission Bug 2086519: exempt build controller SA from PodSecurity admission Jun 1, 2022
@openshift-ci openshift-ci bot added bugzilla/severity-urgent Referenced Bugzilla bug's severity is urgent for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. labels Jun 1, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 1, 2022

@stlaz: This pull request references Bugzilla bug 2086519, which is valid. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.11.0) matches configured target release for branch (4.11.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

No GitHub users were found matching the public email listed for the QA contact in Bugzilla (ytripath@redhat.com), skipping review request.

In response to this:

Bug 2086519: exempt build controller SA from PodSecurity admission

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@stlaz
Copy link
Contributor Author

stlaz commented Jun 1, 2022

/retest-required

@openshift-ci openshift-ci bot mentioned this pull request Jun 1, 2022
Merged
@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 2 against base HEAD 040ecfb and 8 for PR HEAD aab0cba in total

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 1 against base HEAD 040ecfb and 7 for PR HEAD aab0cba in total

@openshift-ci openshift-ci bot mentioned this pull request Jun 1, 2022
Merged
@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 040ecfb and 6 for PR HEAD aab0cba in total

@s-urbaniak
Copy link
Contributor

/retest-required

1 similar comment
@s-urbaniak
Copy link
Contributor

/retest-required

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 3, 2022 •
edited
Loading

@stlaz: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-gcp-operator-single-node aab0cba link false /test e2e-gcp-operator-single-node
ci/prow/e2e-aws-operator-disruptive-single-node aab0cba link false /test e2e-aws-operator-disruptive-single-node
ci/prow/e2e-aws-single-node aab0cba link false /test e2e-aws-single-node

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-ci openshift-ci bot mentioned this pull request Jun 3, 2022
Merged
@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 2 against base HEAD 12b962e and 5 for PR HEAD aab0cba in total

@openshift-merge-robot openshift-merge-robot merged commit ee6d396 into openshift:master Jun 3, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 3, 2022

@stlaz: Some pull requests linked via external trackers have merged:

The following pull requests linked via external trackers have not merged:

These pull request must merge or be unlinked from the Bugzilla bug in order for it to move to the next state. Once unlinked, request a bug refresh with /bugzilla refresh.

Bugzilla bug 2086519 has not been moved to the MODIFIED state.

In response to this:

Bug 2086519: exempt build controller SA from PodSecurity admission

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

This was referenced Jun 17, 2022
Merged
Merged
Merged
Merged
alvaroaleman added a commit to alvaroaleman/hypershift that referenced this pull request Jun 24, 2022
@alvaroaleman
Excempt build controller SA from PodSecurity admission
b15a34b 
Mirrors
openshift/cluster-kube-apiserver-operator#1358
@alvaroaleman alvaroaleman mentioned this pull request Jun 24, 2022
Merged
4 tasks
openshift-cherrypick-robot pushed a commit to openshift-cherrypick-robot/hypershift that referenced this pull request Jun 24, 2022
@alvaroaleman
Excempt build controller SA from PodSecurity admission
e6ae026 
Mirrors
openshift/cluster-kube-apiserver-operator#1358
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@deads2k deads2k deads2k left review comments

@s-urbaniak s-urbaniak Awaiting requested review from s-urbaniak

@mfojtik mfojtik Awaiting requested review from mfojtik

@sttts sttts Awaiting requested review from sttts

Assignees

@s-urbaniak s-urbaniak

@deads2k deads2k

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-urgent Referenced Bugzilla bug's severity is urgent for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@stlaz @deads2k @s-urbaniak @openshift-ci-robot @openshift-merge-robot