Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add RBAC for PSa label syncing controller #616

Merged
merged 1 commit into from
May 10, 2022
Merged

add RBAC for PSa label syncing controller #616

merged 1 commit into from
May 10, 2022

Conversation

stlaz
Copy link
Contributor

@stlaz stlaz commented Apr 22, 2022

Adds clusterrole and its binding for openshift/cluster-policy-controller#75

/hold
until the related PR gets approved

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 22, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Apr 22, 2022 •
edited
Loading

@stlaz: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-aws-ccm b811a17 link false /test e2e-aws-ccm

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@stlaz stlaz mentioned this pull request Apr 25, 2022
Merged
@s-urbaniak
Copy link
Contributor

/lgtm

@stlaz
Copy link
Contributor Author

stlaz commented May 10, 2022

/hold cancel

@openshift-ci openshift-ci bot added lgtm Indicates that a PR is ready to be merged. and removed do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. labels May 10, 2022
soltysh
soltysh approved these changes May 10, 2022
View reviewed changes
Copy link

@soltysh soltysh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@openshift-ci
Copy link
Contributor

openshift-ci bot commented May 10, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: s-urbaniak, soltysh, stlaz

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 10, 2022
@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

6 similar comments
@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit bb2f881 into openshift:master May 10, 2022
csrwng added a commit to csrwng/hypershift-1 that referenced this pull request Dec 6, 2022
@csrwng
policy-controller: add missing rbac
9059b42 
PodSecurityAdmissionController RBAC was added here: openshift/cluster-kube-controller-manager-operator#616. We need to do the same.
@csrwng csrwng mentioned this pull request Dec 6, 2022
Merged
1 task
csrwng added a commit to csrwng/hypershift-1 that referenced this pull request Dec 16, 2022
@csrwng
policy-controller: add missing rbac
107f838 
PodSecurityAdmissionController RBAC was added here: openshift/cluster-kube-controller-manager-operator#616. We need to do the same.
csrwng added a commit to csrwng/hypershift-1 that referenced this pull request Jan 16, 2023
@csrwng
policy-controller: add missing rbac
c386260 
PodSecurityAdmissionController RBAC was added here: openshift/cluster-kube-controller-manager-operator#616. We need to do the same.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@soltysh soltysh soltysh approved these changes

@atiratree atiratree Awaiting requested review from atiratree

@ravisantoshgudimetla ravisantoshgudimetla Awaiting requested review from ravisantoshgudimetla

Assignees

@s-urbaniak s-urbaniak

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@stlaz @s-urbaniak @openshift-bot @soltysh @openshift-merge-robot