Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OCPBUGS-42418: Solved the knative test issue when instances are not present #14325

Conversation

sanketpathak
Copy link
Contributor

@openshift-ci-robot openshift-ci-robot added jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Sep 25, 2024
@openshift-ci-robot
Copy link
Contributor

@sanketpathak: This pull request references Jira Issue OCPBUGS-42418, which is invalid:

  • expected the bug to target the "4.18.0" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

Issue: https://issues.redhat.com/browse/OCPBUGS-42418

Before:
Screenshot from 2024-09-25 14-02-29

Now:
Screenshot from 2024-09-25 14-47-35

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot added component/dev-console Related to dev-console approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Sep 25, 2024
@openshift-ci-robot openshift-ci-robot added the jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. label Sep 25, 2024
@openshift-ci-robot
Copy link
Contributor

@logonoff: This pull request references Jira Issue OCPBUGS-42418, which is valid.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.18.0) matches configured target version for branch (4.18.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @sanketpathak

In response to this:

/jira refresh

Tests don't seem to be working when I run them locally

image

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot openshift-ci-robot removed the jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. label Sep 25, 2024
Copy link
Contributor

openshift-ci bot commented Sep 25, 2024

@openshift-ci-robot: GitHub didn't allow me to request PR reviews from the following users: sanketpathak.

Note that only openshift members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

@logonoff: This pull request references Jira Issue OCPBUGS-42418, which is valid.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.18.0) matches configured target version for branch (4.18.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @sanketpathak

In response to this:

/jira refresh

Tests don't seem to be working when I run them locally

image

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Copy link
Member

@logonoff logonoff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests don't seem to be working when I run them locally

image

/jira refresh

@sanketpathak
Copy link
Contributor Author

Tests don't seem to be working when I run them locally

image

/jira refresh

The bug only fixes the issue with knative installation script when any CR instance is missing in a cluster with knative operator already installed. But I'll push the change for the issue you are facing.

@sanketpathak sanketpathak force-pushed the OCPBUGS-42418-improve-knative-installation branch from 3b6edd9 to f5ae4e7 Compare September 26, 2024 20:25
@openshift-ci openshift-ci bot added kind/cypress Related to Cypress e2e integration testing and removed approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Sep 26, 2024
@sanketpathak sanketpathak force-pushed the OCPBUGS-42418-improve-knative-installation branch from f5ae4e7 to 1f85dd5 Compare September 27, 2024 08:21
@openshift-ci openshift-ci bot added the component/knative Related to knative-plugin label Sep 27, 2024
@sanketpathak sanketpathak force-pushed the OCPBUGS-42418-improve-knative-installation branch from 1f85dd5 to 0b9768a Compare September 27, 2024 08:22
Copy link
Member

@logonoff logonoff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Tests are passing locally

image

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Sep 27, 2024
Copy link
Member

@vikram-raj vikram-raj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

Copy link
Contributor

openshift-ci bot commented Sep 27, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: logonoff, sanketpathak, vikram-raj

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 27, 2024
Copy link
Contributor

openshift-ci bot commented Sep 28, 2024

@sanketpathak: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot bot merged commit 9789f25 into openshift:master Sep 28, 2024
6 checks passed
@openshift-ci-robot
Copy link
Contributor

@sanketpathak: Jira Issue OCPBUGS-42418: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-42418 has been moved to the MODIFIED state.

In response to this:

Issue: https://issues.redhat.com/browse/OCPBUGS-42418

Before:
Screenshot from 2024-09-25 14-02-29

Now:
Screenshot from 2024-09-25 14-47-35

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-bot
Copy link
Contributor

[ART PR BUILD NOTIFIER]

Distgit: openshift-enterprise-console
This PR has been included in build openshift-enterprise-console-container-v4.18.0-202409280309.p0.g9789f25.assembly.stream.el9.
All builds following this will include this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. component/dev-console Related to dev-console component/knative Related to knative-plugin jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. kind/cypress Related to Cypress e2e integration testing lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants