Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OCPBUGS-31367: include external labels so silenced alerts not displayed in notifications #14464

Merged
merged 1 commit into from
Nov 13, 2024
Merged

OCPBUGS-31367: include external labels so silenced alerts not displayed in notifications #14464

merged 1 commit into from
Nov 13, 2024

Conversation

jgbernalp
Copy link
Contributor

@jgbernalp jgbernalp commented Nov 4, 2024 •
edited
Loading

This PR adds external labels to Redux alerts to hide silenced alerts from notifications.

Screen.Recording.2024-11-05.at.09.31.47.mov

@jgbernalp jgbernalp changed the title include external labels so silenced alerts not displayed in notifications OCPBUGS-31367: include external labels so silenced alerts not displayed in notifications Nov 4, 2024
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Nov 4, 2024
@openshift-ci-robot
Copy link
Contributor

@jgbernalp: This pull request references Jira Issue OCPBUGS-31367, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.18.0) matches configured target version for branch (4.18.0)
  • bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @yapei

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

This PR adds the external labels to the alerts stored in redux to be able to effectively hide them from the notifications when the alert is silenced.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot openshift-ci-robot added the jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. label Nov 4, 2024
@openshift-ci openshift-ci bot added component/core Related to console core functionality component/monitoring Related to monitoring approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Nov 4, 2024
@openshift-ci-robot
Copy link
Contributor

@jgbernalp: This pull request references Jira Issue OCPBUGS-31367, which is valid.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.18.0) matches configured target version for branch (4.18.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @yapei

In response to this:

This PR adds external labels to Redux alerts to hide silenced alerts from notifications.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@jgbernalp
Copy link
Contributor Author

Docs Approver:
/assign @opayne1

PX Approver:
/assign @reestr

@PeterYurkovich
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Nov 5, 2024
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Nov 5, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jgbernalp, PeterYurkovich

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@opayne1
Copy link
Contributor

opayne1 commented Nov 5, 2024

/label docs-approved

@openshift-ci openshift-ci bot added the docs-approved Signifies that Docs has signed off on this PR label Nov 5, 2024
@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 0 against base HEAD eb90edb and 2 for PR HEAD f3c27b8 in total

@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 0 against base HEAD 1533f64 and 1 for PR HEAD f3c27b8 in total

@jgbernalp
Copy link
Contributor Author

/retest-required

@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 0 against base HEAD 2bce638 and 0 for PR HEAD f3c27b8 in total

@openshift-ci-robot
Copy link
Contributor

/hold

Revision f3c27b8 was retested 3 times: holding

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 7, 2024
@jgbernalp
Copy link
Contributor Author

/test e2e-gcp-console

@jgbernalp
Copy link
Contributor Author

/unhold

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 12, 2024
@reestr
Copy link

reestr commented Nov 12, 2024

/label px-approved

@openshift-ci openshift-ci bot added the px-approved Signifies that Product Support has signed off on this PR label Nov 12, 2024
@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 0 against base HEAD 3a115ff and 2 for PR HEAD f3c27b8 in total

@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 0 against base HEAD 4df2ddc and 2 for PR HEAD f3c27b8 in total

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Nov 12, 2024

@jgbernalp: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot bot merged commit 4ca6d0a into openshift:master Nov 13, 2024
6 checks passed
@openshift-ci-robot
Copy link
Contributor

@jgbernalp: Jira Issue OCPBUGS-31367: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-31367 has been moved to the MODIFIED state.

In response to this:

This PR adds external labels to Redux alerts to hide silenced alerts from notifications.

Screen.Recording.2024-11-05.at.09.31.47.mov

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-bot
Copy link
Contributor

[ART PR BUILD NOTIFIER]

Distgit: openshift-enterprise-console
This PR has been included in build openshift-enterprise-console-container-v4.18.0-202411130408.p0.g4ca6d0a.assembly.stream.el9.
All builds following this will include this PR.

@jgbernalp
Copy link
Contributor Author

/cherry-pick release-4.17

@openshift-cherrypick-robot
Copy link

@jgbernalp: new pull request created: #14511

In response to this:

/cherry-pick release-4.17

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Nov 19, 2024
Merged
@PeterYurkovich PeterYurkovich mentioned this pull request Dec 10, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PeterYurkovich PeterYurkovich Awaiting requested review from PeterYurkovich

@TheRealJon TheRealJon Awaiting requested review from TheRealJon

@yapei yapei Awaiting requested review from yapei

Assignees

@reestr reestr

@PeterYurkovich PeterYurkovich

@opayne1 opayne1

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. component/core Related to console core functionality component/monitoring Related to monitoring docs-approved Signifies that Docs has signed off on this PR jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. px-approved Signifies that Product Support has signed off on this PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@jgbernalp @openshift-ci-robot @PeterYurkovich @opayne1 @reestr @openshift-bot @openshift-cherrypick-robot