ODC-7720: Add dev perspective nav options to admin perspective #14588

vikram-raj · 2024-12-05T09:58:41Z

Story: https://issues.redhat.com/browse/ODC-7720

Descriptions:

Add Software Catalog nav option under the Home section in the Admin perspective
Add Helm nav option below Operators option in the Admin perspective
Add Functions nav option under the Serverlesssection in the Admin perspective

ODC-7720.mov

openshift-ci-robot · 2024-12-05T09:58:44Z

@vikram-raj: This pull request references ODC-7720 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.19.0" version, but no target version was set.

In response to this:

Story: https://issues.redhat.com/browse/ODC-7720

Descriptions:

Add Software Catalog nav option under the Home section in the Admin perspective

Add Helm nav option below Operators option in the Admin perspective

Add Functions nav option under the Serverlesssection in the Admin perspective

ODC-7720.mov

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-ci · 2024-12-05T09:59:03Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: vikram-raj

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~frontend/OWNERS~~ [vikram-raj]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

vikram-raj · 2024-12-05T10:00:51Z

cc: @jhadvig @spadgett

spadgett · 2024-12-05T11:33:04Z

cc @kevinhatchoua @itsptk

spadgett · 2024-12-05T11:40:37Z

frontend/packages/dev-console/console-extensions.json

+      "href": "/topology",
+      "namespaced": true,
+      "dataAttributes": {
+        "data-quickstart-id": "qs-nav-topology",


This makes me realize that we should look at the quick starts to see what changes are needed for the combined perspective. We should track that as a story under the convergence epic.

Sure I will create a story for a quick start under epic ODC-7716

spadgett

Thank you @vikram-raj 👍

spadgett · 2024-12-05T12:47:56Z

frontend/packages/helm-plugin/src/components/list-page/AdminHelmReleaseListPage.tsx

While this isn't a lot of code, is there a reason we can't reuse the dev console list page here and for helm repositories? Are there not corresponding pages on the dev side?

We have a list page for this and using the same, I need to create this component as in dev perspective Helm page is tabbed view and the list page component does not contain a title, create button and Namespace selector.

spadgett · 2024-12-05T21:36:04Z

frontend/packages/helm-plugin/src/components/list-page/AdminHelmReleaseListPage.tsx

+
+const PageContents: React.FC<PageContentsProps> = ({ namespace }) => {
+  const { t } = useTranslation();
+  return namespace ? (


We should support showing releases in all namespaces (for users with authority) rather than falling back to the project list in the admin/converged perspective.

Agree, I will update it. As an Admin perspective do support All namespaces.

spadgett · 2024-12-05T21:36:23Z

frontend/packages/helm-plugin/src/components/list-page/AdminHelmRepositoriesListPage.tsx

+
+const PageContents: React.FC<PageContentsProps> = ({ namespace }) => {
+  const { t } = useTranslation();
+  return namespace ? (


Support an all namespaces list?

spadgett · 2024-12-05T21:39:04Z

frontend/packages/dev-console/console-extensions.json

+      "id": "software-catalog",
+      "perspective": "admin",
+      "section": "home",
+      "name": "%devconsole~Software Catalog%",


I worry that this will be confused with OperatorHub, although I know this is in @kevinhatchoua's mock. This is the +Add page on the dev side, correct? I also worry that we'll have different labels in the admin and dev perspectives when they're both enabled.

No, it is not a +Add page. It is a Catalog page showing all the catalogs of 'Builder Images, DevFiles, Templates, Event Sources`, etc. We should have the same labels in both perspectives, as there is no difference in content. Software Catalog in Admin and Developer Catalog in the Dev perspective.

lokanandaprabhu

On creating of serverless function, user is redirected to workloads tab in Project details page.

Screen.Recording.2024-12-09.at.1.53.51.PM.mov

vikram-raj · 2024-12-09T11:04:29Z

On creating of serverless function, user is redirected to workloads tab in Project details page.

It was an expected behavior as that's a topology page in the admin perspective. But now we have a Topology page in admin perspective we should redirect the user to that page. I will update it.

lokanandaprabhu

If I am in Helm release or repositories page and onClick of Helm release or repository, select item in the left navigation menu is not proper.

Screen.Recording.2024-12-10.at.11.49.22.AM.mov

Developer catalog is replaced as Software catalog in navigation menu and page title but if I select a catalog type, breadcrumbs is still mentioned as developer catalog and in the highlighted description also. is this fine? or else can we keep in all the places as either Software catalog or Developer catalog?

Screen.Recording.2024-12-10.at.11.53.42.AM.mov

openshift-ci · 2024-12-10T13:31:09Z

@vikram-raj: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/okd-scos-e2e-aws-ovn	`91705b7`	link	false	`/test okd-scos-e2e-aws-ovn`

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

lokanandaprabhu

For Helm repository details page, if it is Helm chart repository, breadcrumbs is redirecting to Helm Chart Repositories list page and if it is PHCR, breadcrumbs is redirecting to Project Helm Chart Repositories list page unlike the behaviour in existing design where breadcrumbs redirecting to Repositories list page irrespective of whether it is HCR or PHCR.

----New design---

Screen.Recording.2024-12-11.at.11.41.26.AM.mov

---Old design----

Screen.Recording.2024-12-11.at.11.46.03.AM.mov

vikram-raj · 2024-12-11T10:11:04Z

@lokanandaprabhu I have fixed the breadcrumb link in the dev perspective. And I asked UX whether we can expose the HCR and PHCR directly as nav items instead of combining both in the single list page.

Add dev perspective nav options to admin perspective

9fad8f7

openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Dec 5, 2024

openshift-ci bot requested review from christoph-jerolimov and lokanandaprabhu December 5, 2024 09:58

openshift-ci bot added the component/core Related to console core functionality label Dec 5, 2024

spadgett reviewed Dec 5, 2024

View reviewed changes

show helm releases from all namespace in admin perspective

94de1a8

lokanandaprabhu reviewed Dec 9, 2024

View reviewed changes

vikram-raj added 2 commits December 9, 2024 20:15

show helm chart repositories from all namespace in admin perspective

8a6e4e4

Redirect from the create form to Topology page

4128ecf

vikram-raj requested review from lokanandaprabhu and spadgett December 9, 2024 14:52

Update the Catalog page title to 'Software Catalog' in admin perspective

336b2cf

lokanandaprabhu reviewed Dec 10, 2024

View reviewed changes

vikram-raj added 2 commits December 10, 2024 13:55

fix helm repositories create form URL

4eb4964

Fix catalog breadcrum

91705b7

openshift-ci bot added the component/shared Related to console-shared label Dec 10, 2024

lokanandaprabhu reviewed Dec 11, 2024

View reviewed changes

Fix helm repositories breadcrums link in dev perspective

29ab9cc

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

ODC-7720: Add dev perspective nav options to admin perspective #14588

ODC-7720: Add dev perspective nav options to admin perspective #14588

vikram-raj commented Dec 5, 2024

openshift-ci-robot commented Dec 5, 2024 •

edited by openshift-ci bot

Loading

openshift-ci bot commented Dec 5, 2024

vikram-raj commented Dec 5, 2024

spadgett commented Dec 5, 2024

spadgett Dec 5, 2024

vikram-raj Dec 5, 2024

spadgett left a comment •

edited

Loading

spadgett Dec 5, 2024

vikram-raj Dec 5, 2024

spadgett Dec 5, 2024

vikram-raj Dec 6, 2024

spadgett Dec 5, 2024

spadgett Dec 5, 2024

vikram-raj Dec 6, 2024

lokanandaprabhu left a comment

vikram-raj commented Dec 9, 2024 •

edited

Loading

lokanandaprabhu left a comment

openshift-ci bot commented Dec 10, 2024

lokanandaprabhu left a comment

vikram-raj commented Dec 11, 2024

ODC-7720: Add dev perspective nav options to admin perspective #14588

Are you sure you want to change the base?

ODC-7720: Add dev perspective nav options to admin perspective #14588

Conversation

vikram-raj commented Dec 5, 2024

openshift-ci-robot commented Dec 5, 2024 • edited by openshift-ci bot Loading

openshift-ci bot commented Dec 5, 2024

vikram-raj commented Dec 5, 2024

spadgett commented Dec 5, 2024

Choose a reason for hiding this comment

Choose a reason for hiding this comment

spadgett left a comment • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

lokanandaprabhu left a comment

Choose a reason for hiding this comment

vikram-raj commented Dec 9, 2024 • edited Loading

lokanandaprabhu left a comment

Choose a reason for hiding this comment

openshift-ci bot commented Dec 10, 2024

lokanandaprabhu left a comment

Choose a reason for hiding this comment

vikram-raj commented Dec 11, 2024

openshift-ci-robot commented Dec 5, 2024 •

edited by openshift-ci bot

Loading

spadgett left a comment •

edited

Loading

vikram-raj commented Dec 9, 2024 •

edited

Loading