CONSOLE-3031: Remove font-awesome and openshift-logos-icon

[logonoff]

CONSOLE Features and Fixes:

https://issues.redhat.com/browse/CONSOLE-3031

Solution description

• Removed font-awesome
• Removed openshift-logos-icon due to non-usage
• fa-spin was changed to a custom co-spin,
• the font-awesome usage in pesudoelement co-external-link and co-goto-arrow were replaced with mask-images (so that the icons can retain the text color while keeping usage the same),
• co-modal-btn-link was removed due to non-usage across actively maintained dynamic plugins on GitHub
• Font awesome icons used in React were replaced with the PatternFly equivalent
  • if the html element was stored as a string then inserted into the DOM later, a function getSvgFromPfIconConfig was written to generate an SVG element from the PatternFly icon exports

Test cases:

• All icons changed should look about the same

Screen shots / gifs / design review:

Corporate needs you to find the differences between this picture and this picture:

Before:

After:

[openshift-ci-robot]

@logonoff: This pull request references CONSOLE-3031 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.19.0" version, but no target version was set.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[rhamilto]

A few comments around imports and icons that are available in PatternFly

[openshift-ci-robot]

@logonoff: This pull request references CONSOLE-3031 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.19.0" version, but no target version was set.

In response to this:

Before:

After:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[logonoff]

/retest

[openshift-ci-robot]

@logonoff: This pull request references CONSOLE-3031 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.19.0" version, but no target version was set.

In response to this:

CONSOLE Features and Fixes:

https://issues.redhat.com/browse/CONSOLE-3031

Solution description

• Removed font-awesome
• Removed openshift-logos-icon due to non-usage
• fa-spin was changed to a custom co-spin,
• the font-awesome usage in pesudoelement co-external-link and co-goto-arrow were replaced with mask-images (so that the icons can retain the text color while keeping usage the same),
• co-modal-btn-link was removed due to non-usage across actively maintained dynamic plugins on GitHub
• Font awesome icons used in React were replaced with the PatternFly equivalent
• if the html element was stored as a string then inserted into the DOM later, a function getSvgFromPfIconConfig was written to generate an SVG element from the PatternFly icon exports

Test cases:

Everything should look the same

Screen shots / gifs / design review:

Corporate needs you to find the differences between this picture and this picture:

Before:

After:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[logonoff]

adding labels because this is debt:

/label px-approved
/label docs-approved

QE review:

/cc @yapei

[openshift-ci-robot]

@logonoff: This pull request references CONSOLE-3031 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.19.0" version, but no target version was set.

In response to this:

CONSOLE Features and Fixes:

https://issues.redhat.com/browse/CONSOLE-3031

Solution description

• Removed font-awesome
• Removed openshift-logos-icon due to non-usage
• fa-spin was changed to a custom co-spin,
• the font-awesome usage in pesudoelement co-external-link and co-goto-arrow were replaced with mask-images (so that the icons can retain the text color while keeping usage the same),
• co-modal-btn-link was removed due to non-usage across actively maintained dynamic plugins on GitHub
• Font awesome icons used in React were replaced with the PatternFly equivalent
• if the html element was stored as a string then inserted into the DOM later, a function getSvgFromPfIconConfig was written to generate an SVG element from the PatternFly icon exports

Test cases:

Everything should look the same

Screen shots / gifs / design review:

Corporate needs you to find the differences between this picture and this picture:

Before:

After:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-ci-robot]

@logonoff: This pull request references CONSOLE-3031 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.19.0" version, but no target version was set.

In response to this:

CONSOLE Features and Fixes:

https://issues.redhat.com/browse/CONSOLE-3031

Solution description

• Removed font-awesome
• Removed openshift-logos-icon due to non-usage
• fa-spin was changed to a custom co-spin,
• the font-awesome usage in pesudoelement co-external-link and co-goto-arrow were replaced with mask-images (so that the icons can retain the text color while keeping usage the same),
• co-modal-btn-link was removed due to non-usage across actively maintained dynamic plugins on GitHub
• Font awesome icons used in React were replaced with the PatternFly equivalent
• if the html element was stored as a string then inserted into the DOM later, a function getSvgFromPfIconConfig was written to generate an SVG element from the PatternFly icon exports

Test cases:

• All icons changed should look about the same

Screen shots / gifs / design review:

Corporate needs you to find the differences between this picture and this picture:

Before:

After:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[rhamilto]

/approve
/lgtm
/label acknowledge-critical-fixes-only

[rhamilto]

/label tide/merge-method-squash

[rhamilto]

/lgtm

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: logonoff, rhamilto

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• frontend/OWNERS [rhamilto]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[rhamilto]

/test okd-scos-e2e-aws-ovn

[rhamilto]

/test okd-scos-e2e-aws-ovn

[openshift-ci]

@logonoff: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/okd-scos-e2e-aws-ovn	1c8bac1	link	false	/test okd-scos-e2e-aws-ovn

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

[yanpzhan]

Checked on cluster launched against the pr, check some pages on console including the screenshots in the pr description, there is not regression issue found.
/label qe-approved

[openshift-ci-robot]

@logonoff: This pull request references CONSOLE-3031 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.19.0" version, but no target version was set.

In response to this:

CONSOLE Features and Fixes:

https://issues.redhat.com/browse/CONSOLE-3031

Solution description

• Removed font-awesome
• Removed openshift-logos-icon due to non-usage
• fa-spin was changed to a custom co-spin,
• the font-awesome usage in pesudoelement co-external-link and co-goto-arrow were replaced with mask-images (so that the icons can retain the text color while keeping usage the same),
• co-modal-btn-link was removed due to non-usage across actively maintained dynamic plugins on GitHub
• Font awesome icons used in React were replaced with the PatternFly equivalent
• if the html element was stored as a string then inserted into the DOM later, a function getSvgFromPfIconConfig was written to generate an SVG element from the PatternFly icon exports

Test cases:

• All icons changed should look about the same

Screen shots / gifs / design review:

Corporate needs you to find the differences between this picture and this picture:

Before:

After:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.