-
Notifications
You must be signed in to change notification settings - Fork 615
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OCPBUGS-45987: Fix alert rule link to alert in dev perspective #14608
base: release-4.18
Are you sure you want to change the base?
OCPBUGS-45987: Fix alert rule link to alert in dev perspective #14608
Conversation
@PeterYurkovich: This pull request references Jira Issue OCPBUGS-45987, which is invalid:
Comment The bug has been updated to refer to the pull request using the external bug tracker. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: PeterYurkovich The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/retest |
@PeterYurkovich: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
This PR looks to solve an issue which caused alert rules links in the developer perspective to create an invalid link back the individual alerts.
In order to fix an issue with showing silenced alerts in the notification bell, we added the external labels to alerts which aren't in the developer perspective in #14464.
The location which poll for the alert rule page didn't check the perspective, so the extra labels were added to each alert. When the labels were then converted to query parameters for the link to the alert page, the external labels were also included leading to an invalid link.
This PR passes in the perspective information to the
getAlertsAndRules
function so that the external labels aren't added.