Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OCPBUGS-45987: Fix alert rule link to alert in dev perspective #14608

Open
wants to merge 1 commit into
base: release-4.18
Choose a base branch
from

Conversation

PeterYurkovich
Copy link
Contributor

This PR looks to solve an issue which caused alert rules links in the developer perspective to create an invalid link back the individual alerts.

In order to fix an issue with showing silenced alerts in the notification bell, we added the external labels to alerts which aren't in the developer perspective in #14464.

The location which poll for the alert rule page didn't check the perspective, so the extra labels were added to each alert. When the labels were then converted to query parameters for the link to the alert page, the external labels were also included leading to an invalid link.

This PR passes in the perspective information to the getAlertsAndRules function so that the external labels aren't added.

@openshift-ci-robot openshift-ci-robot added jira/severity-moderate Referenced Jira bug's severity is moderate for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. labels Dec 10, 2024
@openshift-ci-robot
Copy link
Contributor

@PeterYurkovich: This pull request references Jira Issue OCPBUGS-45987, which is invalid:

  • release note text must be set and not match the template OR release note type must be set to "Release Note Not Required". For more information you can reference the OpenShift Bug Process.
  • expected Jira Issue OCPBUGS-45987 to depend on a bug targeting a version in 4.19.0 and in one of the following states: MODIFIED, ON_QA, VERIFIED, but no dependents were found

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

This PR looks to solve an issue which caused alert rules links in the developer perspective to create an invalid link back the individual alerts.

In order to fix an issue with showing silenced alerts in the notification bell, we added the external labels to alerts which aren't in the developer perspective in #14464.

The location which poll for the alert rule page didn't check the perspective, so the extra labels were added to each alert. When the labels were then converted to query parameters for the link to the alert page, the external labels were also included leading to an invalid link.

This PR passes in the perspective information to the getAlertsAndRules function so that the external labels aren't added.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot openshift-ci-robot added the jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. label Dec 10, 2024
@openshift-ci openshift-ci bot added the component/dev-console Related to dev-console label Dec 10, 2024
Copy link
Contributor

openshift-ci bot commented Dec 10, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: PeterYurkovich
Once this PR has been reviewed and has the lgtm label, please assign invinciblejai for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@PeterYurkovich
Copy link
Contributor Author

/retest

Copy link
Contributor

openshift-ci bot commented Dec 10, 2024

@PeterYurkovich: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component/dev-console Related to dev-console jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. jira/severity-moderate Referenced Jira bug's severity is moderate for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants