From 049d1077d98c048141ad86b1c483cdb09a65b6b7 Mon Sep 17 00:00:00 2001 From: Yanir Quinn Date: Tue, 5 Oct 2021 11:31:03 +0300 Subject: [PATCH] Add controller-runtime option to code section --- enhancements/node-tuning/pao-in-nto.md | 14 ++++++++++++-- 1 file changed, 12 insertions(+), 2 deletions(-) diff --git a/enhancements/node-tuning/pao-in-nto.md b/enhancements/node-tuning/pao-in-nto.md index 2b0d030a7f0..e1c57467bd6 100644 --- a/enhancements/node-tuning/pao-in-nto.md +++ b/enhancements/node-tuning/pao-in-nto.md @@ -103,8 +103,8 @@ that can be used to PAO code would be moved into the NTO repository as a separate controller. The Telco team would keep ownership as it has the necessary domain knowledge needed to implement the low latency tuning. The code currently uses Operator SDK libraries in some of the tests and this might need to be changed. -Migrating the use of these libaries to [library-go](https://github.com/openshift/library-go) -would be one of the options. +Migrating the use of these libraries to [library-go](https://github.com/openshift/library-go) or stripping them to [controller-runtime](https://github.com/kubernetes-sigs/controller-runtime) +would be options in hand. PAO also implements a [conversion webhook](https://kubernetes.io/docs/tasks/extend-kubernetes/custom-resources/custom-resource-definition-versioning/#webhook-conversion) The hook is currently installed via OLM mechanisms and this might need to be reimplemented or changed to use whatever CVO or ART support. @@ -147,6 +147,9 @@ The bugzilla component is currently not part of OCP metrics and we can include i Both the NTO and PAO functionality should be kept intact and no regressions are allowed. The user should not notice anything except the fact that OLM is no longer needed to enable the tuning functionality. +### API Extensions +The existing PAO API Extensions will be moved under the NTO repository. + ### Implementation Details/Notes/Constraints - Existing api compatibility practices: @@ -200,6 +203,7 @@ NTO currently supports only one cloud installation with external control plane t - Implementation: - Remove the relevant OLM artifacts (CSV,Subscription,Operator group) via the performance-addon controller and leave the PAO CRDs without the change. - In case leader election supports such conditioning, is to keep using the same leadership election method and make sure the newest version always wins. The OLM operator will then stay on the cluster (can be release noted) as an inactive component. + ### Test Plan All tests already exist in OCP CI, the trigger will move to the NTO repository. @@ -280,6 +284,12 @@ enhancement: - Will any other components on the node change? For example, changes to CSI, CRI or CNI may require updating that component before the kubelet. +### Operational Aspects of API Extensions + +#### Failure Modes + +#### Support Procedures + ## Implementation History Major milestones in the life cycle of a proposal should be tracked in `Implementation