Skip to content

Commit

Permalink
fix wording about conversion hook
Browse files Browse the repository at this point in the history
  • Loading branch information
yanirq committed Sep 29, 2021
1 parent 418338f commit d2f4b79
Showing 1 changed file with 3 additions and 3 deletions.
6 changes: 3 additions & 3 deletions enhancements/node-tuning/pao-in-nto.md
Original file line number Diff line number Diff line change
Expand Up @@ -102,11 +102,11 @@ that can be used to
PAO code would be moved into the NTO repository as a separate controller. The Telco team would keep ownership as it has the necessary domain knowledge needed to implement the low latency tuning.

The code currently uses Operator SDK libraries in some of the tests and this might need to be changed.
Migrating the use of these libaries to [client-go](https://github.com/openshift/library-go)
Migrating the use of these libaries to [library-go](https://github.com/openshift/library-go)
would be one of the options.

PAO also implements a [conversion webhook](https://kubernetes.io/docs/tasks/extend-kubernetes/custom-resources/custom-resource-definition-versioning/#webhook-conversion)
to migrate its custom resources during upgrade.
to convert its custom resources during upgrade to versions that are supported by the openshift version targeted.
The hook is currently installed via OLM mechanisms and this might need to be reimplemented or changed to use whatever CVO or ART support.
PAO must-gather will have the native support with additional arguments and will not require an additional image as currently exists in PAO original repository.

Expand Down Expand Up @@ -220,7 +220,7 @@ The user facing feature is already considered stable and GA, just shipped as an

It is expected that the image will be kept up-to-date as part of regular OCP flows.

API changes are handled by a migration webhook that PAO already contains to make upgrades transparent to users.
API changes are handled by a conversion webhook that PAO already contains to make upgrades transparent to users.

PAO depends on NTO and MCO functionality.

Expand Down

0 comments on commit d2f4b79

Please sign in to comment.