From d2f4b7947103e75d8adc97a75c2f492cf1bb5aa4 Mon Sep 17 00:00:00 2001 From: Yanir Quinn Date: Wed, 29 Sep 2021 12:29:40 +0300 Subject: [PATCH] fix wording about conversion hook --- enhancements/node-tuning/pao-in-nto.md | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/enhancements/node-tuning/pao-in-nto.md b/enhancements/node-tuning/pao-in-nto.md index 5876874b153..57b6b55b3f0 100644 --- a/enhancements/node-tuning/pao-in-nto.md +++ b/enhancements/node-tuning/pao-in-nto.md @@ -102,11 +102,11 @@ that can be used to PAO code would be moved into the NTO repository as a separate controller. The Telco team would keep ownership as it has the necessary domain knowledge needed to implement the low latency tuning. The code currently uses Operator SDK libraries in some of the tests and this might need to be changed. -Migrating the use of these libaries to [client-go](https://github.com/openshift/library-go) +Migrating the use of these libaries to [library-go](https://github.com/openshift/library-go) would be one of the options. PAO also implements a [conversion webhook](https://kubernetes.io/docs/tasks/extend-kubernetes/custom-resources/custom-resource-definition-versioning/#webhook-conversion) -to migrate its custom resources during upgrade. +to convert its custom resources during upgrade to versions that are supported by the openshift version targeted. The hook is currently installed via OLM mechanisms and this might need to be reimplemented or changed to use whatever CVO or ART support. PAO must-gather will have the native support with additional arguments and will not require an additional image as currently exists in PAO original repository. @@ -220,7 +220,7 @@ The user facing feature is already considered stable and GA, just shipped as an It is expected that the image will be kept up-to-date as part of regular OCP flows. -API changes are handled by a migration webhook that PAO already contains to make upgrades transparent to users. +API changes are handled by a conversion webhook that PAO already contains to make upgrades transparent to users. PAO depends on NTO and MCO functionality.