-
Notifications
You must be signed in to change notification settings - Fork 475
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add preliminary data section to network check enhancement. #406
Conversation
/assign @deads2k |
Add *Preliminary Data* section highlighting cases in which the enhancement has provided value.
Issues go stale after 90d of inactivity. Mark the issue as fresh by commenting If this issue is safe to close now please do so with /lifecycle stale |
Stale issues rot after 30d of inactivity. Mark the issue as fresh by commenting If this issue is safe to close now please do so with /lifecycle rotten |
It would be great to have links that show how the analysis was done and these conclusions were reached. If any of that is in a place you can link to, a follow-up PR would be great. I don't know if CI job artifacts ever get garbage collected, but if they do, I suppose the links you've included will stop working. In any case, this looks like something we should just merge. Sorry it sat so long. /approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: russellb The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/retest |
/retest Please review the full test history for this PR and help us cut down flakes. |
7 similar comments
/retest Please review the full test history for this PR and help us cut down flakes. |
/retest Please review the full test history for this PR and help us cut down flakes. |
/retest Please review the full test history for this PR and help us cut down flakes. |
/retest Please review the full test history for this PR and help us cut down flakes. |
/retest Please review the full test history for this PR and help us cut down flakes. |
/retest Please review the full test history for this PR and help us cut down flakes. |
/retest Please review the full test history for this PR and help us cut down flakes. |
@sanchezl can you fix the markdownlint issues? Thanks! |
@sanchezl: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
Issues go stale after 90d of inactivity. Mark the issue as fresh by commenting If this issue is safe to close now please do so with /lifecycle stale |
Stale issues rot after 30d of inactivity. Mark the issue as fresh by commenting If this issue is safe to close now please do so with /lifecycle rotten |
Rotten issues close after 30d of inactivity. Reopen the issue by commenting /close |
@openshift-bot: Closed this PR. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Add Preliminary Data section highlighting cases in which the enhancement has provided value.
namespaces/openshift-kube-apiserver/controlplane.operator.openshift.io/podnetworkconnectivitychecks/kube-apiserver-ci-op-v92gtp5p-77d57-ds8mq-master-1-to-openshift-apiserver-service-172-30-23-188-443.yaml
at "2020-07-22T13:37:21Z"