Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update machine-api-usage-telemetry #538

Closed
wants to merge 1 commit into from
Closed

update machine-api-usage-telemetry #538

wants to merge 1 commit into from

Conversation

elmiko
Copy link
Contributor

@elmiko elmiko commented Nov 13, 2020 •
edited
Loading

During implementation of this enhancement we have determined that there
will be a need for two labels on the MachineHealthCheck related
metrics. Although these labels have unbounded cardinality, it will only
need to be exported through telemetry as a sum without the need for the
labels.

@elmiko
Copy link
Contributor Author

elmiko commented Nov 13, 2020

@JoelSpeed @smarterclayton @lilic @s-urbaniak ptal

JoelSpeed
JoelSpeed reviewed Nov 16, 2020
View reviewed changes
Copy link
Contributor

@JoelSpeed JoelSpeed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Thanks for keeping this up to date

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Nov 16, 2020
@openshift-ci-robot openshift-ci-robot removed the lgtm Indicates that a PR is ready to be merged. label Nov 18, 2020
@elmiko
Copy link
Contributor Author

elmiko commented Nov 18, 2020

updated to include the namespace labels as well

@JoelSpeed
Copy link
Contributor

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Nov 19, 2020
@openshift-bot
Copy link

Issues go stale after 90d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.
Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle stale

@openshift-ci-robot openshift-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Feb 17, 2021
@elmiko
Copy link
Contributor Author

elmiko commented Feb 22, 2021

/remove-lifecycle stale

@openshift-ci-robot openshift-ci-robot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Feb 22, 2021
@elmiko
Copy link
Contributor Author

elmiko commented Feb 23, 2021

putting a hold on this, i'd like to update with a few more changes
/hold

@openshift-ci-robot openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 23, 2021
@elmiko
update machine-api-usage-telemetry
49b0709 
During implementation of this enhancement we have determined that there
will be a need for two labels on the MachineHealthCheck related
metrics. Although these labels have unbounded cardinality, it will only
need to be exported through telemetry as a sum without the need for the
labels.

The alert for machines with old deletion timestamps has been renamed to
`MachineNotYetDeleted`, to better describe the root cause as opposed to
the symptom.
@openshift-ci-robot
Copy link

New changes are detected. LGTM label has been removed.

@openshift-ci-robot openshift-ci-robot added needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. and removed lgtm Indicates that a PR is ready to be merged. labels Feb 23, 2021
@openshift-ci-robot
Copy link

@elmiko: PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Feb 23, 2021

@elmiko: The following test failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
ci/prow/markdownlint 49b0709 link /test markdownlint

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@JoelSpeed
Copy link
Contributor

@elmiko This has a conflict that you'll need to resolve before we can merge this

@elmiko
Copy link
Contributor Author

elmiko commented Feb 24, 2021

yeah, i saw it @JoelSpeed , my plan was to leave the hold in place for now to see if there are further changes needed and then clean this up when i remove the hold.

@JoelSpeed
Copy link
Contributor

Ack, apart from the rebase, I have no issues with the content
/approve

@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JoelSpeed

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 24, 2021
@openshift-bot
Copy link

Issues go stale after 90d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.
Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle stale

@openshift-ci openshift-ci bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label May 26, 2021
@openshift-bot
Copy link

Stale issues rot after 30d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.
Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle rotten
/remove-lifecycle stale

@openshift-ci openshift-ci bot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Jun 25, 2021
@elmiko
Copy link
Contributor Author

elmiko commented Jul 22, 2021

just wanted to leave a note on why this is still open, we have a few metrics/alert changes that are still in flight. i will update this PR once we have them merged.

This was referenced Jul 22, 2021
Merged
Merged
@openshift-bot
Copy link

Rotten issues close after 30d of inactivity.

Reopen the issue by commenting /reopen.
Mark the issue as fresh by commenting /remove-lifecycle rotten.
Exclude this issue from closing again by commenting /lifecycle frozen.

/close

@openshift-ci openshift-ci bot closed this Aug 21, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 21, 2021

@openshift-bot: Closed this PR.

In response to this:

Rotten issues close after 30d of inactivity.

Reopen the issue by commenting /reopen.
Mark the issue as fresh by commenting /remove-lifecycle rotten.
Exclude this issue from closing again by commenting /lifecycle frozen.

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@elmiko
Copy link
Contributor Author

elmiko commented Mar 23, 2022

/reopen

all the issues around this have merged, i would like to update the enhancement so that it is accurate.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Mar 23, 2022

@elmiko: Failed to re-open PR: state cannot be changed. The update-mao-usage-telemetry branch was force-pushed or recreated.

In response to this:

/reopen

all the issues around this have merged, i would like to update the enhancement so that it is accurate.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@elmiko
Copy link
Contributor Author

elmiko commented Mar 23, 2022

superseded by #1072

@elmiko elmiko mentioned this pull request Mar 23, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JoelSpeed JoelSpeed JoelSpeed left review comments

@spadgett spadgett Awaiting requested review from spadgett

@stevekuznetsov stevekuznetsov Awaiting requested review from stevekuznetsov

Assignees

@JoelSpeed JoelSpeed

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@elmiko @JoelSpeed @openshift-bot @openshift-ci-robot