Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NO-JIRA: cmd: dump: include ValidatingAdmissionPolicies in guest cluster dump #5165

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

NO-JIRA: cmd: dump: include ValidatingAdmissionPolicies in guest cluster dump #5165

wants to merge 1 commit into from

Conversation

sjenning
Copy link
Contributor

help investigation CI failure on ValidatingAdmissionPolicy assertions

@openshift-ci-robot
Copy link

@sjenning: This pull request explicitly references no jira issue.

In response to this:

help investigation CI failure on ValidatingAdmissionPolicy assertions

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Nov 20, 2024
@openshift-ci openshift-ci bot added the area/cli Indicates the PR includes changes for CLI label Nov 20, 2024
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Nov 20, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sjenning

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added approved Indicates a PR has been approved by an approver from all required OWNERS files. and removed do-not-merge/needs-area labels Nov 20, 2024
@sjenning
Copy link
Contributor Author

/retest

@EmilienM
Copy link
Member

The failure on e2e-aks is unrelated.
/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Nov 20, 2024
@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 6f18591 and 2 for PR HEAD 003aa01 in total

@jparrill
Copy link
Contributor

/lgtm
/retest

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD f0571d2 and 1 for PR HEAD 003aa01 in total

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD be0b725 and 0 for PR HEAD 003aa01 in total

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Nov 21, 2024

@sjenning: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-aks 003aa01 link true /test e2e-aks

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-ci-robot
Copy link

/hold

Revision 003aa01 was retested 3 times: holding

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 21, 2024
mjlshen
mjlshen reviewed Nov 22, 2024
View reviewed changes
cmd/cluster/core/dump.go
@@ -487,6 +488,7 @@ func DumpGuestCluster(ctx context.Context, log logr.Logger, kubeconfig string, d
// https://github.com/openshift/api/blob/2bde012f248a5172dcde2f7104caf0726cf6d93a/config/v1/types_cluster_version.go#L266-L270
&snapshotv1.VolumeSnapshotClass{},
&snapshotv1.VolumeSnapshotContent{},
&admissionregistrationv1beta1.ValidatingAdmissionPolicy{},
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You may also want to consider including ValidatingAdmissionPolicyBinding resources as well

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mjlshen mjlshen mjlshen left review comments

@enxebre enxebre Awaiting requested review from enxebre

@isco-rodriguez isco-rodriguez Awaiting requested review from isco-rodriguez

Assignees

@jparrill jparrill

@EmilienM EmilienM

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/cli Indicates the PR includes changes for CLI do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@sjenning @openshift-ci-robot @EmilienM @jparrill @mjlshen