OCPBUGS-44910: openstack: don't reconcile image registry config during bootstrap #5178
Conversation
openshift-ci-robot
added
the
jira/valid-reference
|
@EmilienM: This pull request references Jira Issue OCPBUGS-44910, which is valid. The bug has been moved to the POST state. 3 validation(s) were run on this bug
No GitHub users were found matching the public email listed for the QA contact in Jira (rlobillo@redhat.com), skipping review request. The bug has been updated to refer to the pull request using the external bug tracker. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
openshift-ci-robot
added
the
jira/valid-bug
openshift-ci
bot
added
area/control-plane-operator
|
/test e2e-openstack-csi-cinder |
|
/test e2e-aws |
EmilienM
force-pushed
the
OCPBUGS-44910
branch
from
4916158
to
36978f2
Compare
|
/test e2e-openstack-csi-cinder |
EmilienM
force-pushed
the
OCPBUGS-44910
branch
from
36978f2
to
6a70de8
Compare
openshift-ci
bot
added
the
area/documentation
✅ Deploy Preview for hypershift-docs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
/test e2e-openstack-csi-cinder |
|
/cherry-pick release-4.18 |
|
@EmilienM: once the present PR merges, I will cherry-pick it on top of In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/test okd-scos-e2e-aws-ovn |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: csrwng, EmilienM The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
control-plane-operator/hostedclusterconfigoperator/controllers/resources/resources.go
Outdated
Show resolved
Hide resolved
…g bootstrap For platforms where cluster-image-registry-operator (CIRO) needs a PVC to be created, bootstrap needs to happen in CIRO before the registry config is created. For now, this is the case for the OpenStack platform. If the object exist, we reconcile the registry config for other other fields as it should be fine since the PVC would exist at this point. This patch will maintain a list of platforms that require a PVC for CIRO (OpenStack only for now), check whether an image registry config already exist and if it does, skip reconcile to let CIRO bootstrap doing it and creating the needed PVC for CIRO.
EmilienM
force-pushed
the
OCPBUGS-44910
branch
from
6a70de8
to
1341901
Compare
There was a problem hiding this comment.
I'm not clear on the relationship between CIRO and hypershift. If we need in all case for CIRO to write its config once, why don't we make it a needed condition in hypershift (for all platforms)? Why do we need to maintain a list of platforms that might use a PV as the storage for the image registry?
Creating configs before an operator starts seems to be a common design pattern in Hypershift. I'm not sure we want to change that for all the platforms even if it might work for CIRO in this particular case. |
|
/test e2e-aws |
As Emilien mentioned, the reason is to limit the scope of this change to OpenStack. We may eventually want to do it for other platforms as well. But since that does have a broader impact, we want to be more intentional about it and maybe not just do it for CIRO but for other operators as well. |
|
/hold cancel |
openshift-ci
bot
removed
the
do-not-merge/hold
|
/test e2e-aws |
1 similar comment
|
/test e2e-aws |
1 similar comment
|
/test e2e-aks |
2 similar comments
|
/retest-required |
openshift-ci
bot
added
the
do-not-merge/hold
|
/hold cancel |
openshift-ci
bot
removed
the
do-not-merge/hold
|
/test e2e-aws |
|
@EmilienM: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
/test e2e-aws |
openshift-merge-bot
bot
merged commit 8326d86
into
openshift:main
|
@EmilienM: Jira Issue OCPBUGS-44910: All pull requests linked via external trackers have merged: Jira Issue OCPBUGS-44910 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
@EmilienM: new pull request created: #5198 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
[ART PR BUILD NOTIFIER] Distgit: hypershift |
What this PR does / why we need it:
For platforms where cluster-image-registry-operator (CIRO) needs a PVC to be created, bootstrap needs to happen
in CIRO before the registry config is created. For now, this is the case for the OpenStack platform.
If the object exist, we reconcile the registry config for other other fields as it should be fine since the PVC would
exist at this point.
This patch will maintain a list of platforms that require a PVC for CIRO
(OpenStack only for now), check whether an image registry config already
exist and if it does, skip reconcile to let CIRO bootstrap doing it and
creating the needed PVC for CIRO.